Closed Bug 688313 Opened 13 years ago Closed 13 years ago

Give quoted text a highlighted background

Categories

(Add-on SDK Graveyard :: Documentation, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wbamberg, Unassigned)

Details

Attachments

(1 file)

The SDK docs quote stuff using <pre></pre>, like command line input/output, contents of files, and so on. They would be more readable if the quoted sections were highlighted with a background colour.
Attachment #561597 - Flags: review?(adw)
Comment on attachment 561597 [details] [diff] [review]
Highlight sections of the docs quoted with <pre></pre>

Review of attachment 561597 [details] [diff] [review]:
-----------------------------------------------------------------

This looks nice, although the decreased contrast between the the text and background makes the text slightly harder for me to read.  You might try making pre text slightly darker than body text to compensate.
Attachment #561597 - Flags: review?(adw) → review+
Thanks Drew! Landed in https://github.com/mozilla/addon-sdk/commit/9c10bf5f8c14031eda2a013eabc1b46aaf8ee80d.  

> You might try
> making pre text slightly darker than body text to compensate.

It's a good point: I set the text colour to black.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: