688325 - `cfx test` prints core Firefox addon management messages

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

`cfx test` has started printing core Firefox addon management messages to the console ever since commit <https://github.com/mozilla/addon-sdk/commit/33df04a244e705467a50d777cfbb53df9a1d5fad> (Bug 685523: Provide mobile support through "cfx --force-mobile"), which sets `extensions.logging.enabled` to "true":

(addon-sdk)mykbook:annotator myk$ cfx test
Using binary at '/Applications/Nightly.app/Contents/MacOS/firefox-bin'.
Using profile at '/var/folders/bN/bN4Z5w6UEdC60cFgLX32NU+++TI/-Tmp-/tmpom0YT6.mozrunner'.
*** LOG addons.manager: Application has been upgraded
*** LOG addons.xpi: startup
*** LOG addons.xpi: checkForChanges
*** LOG addons.xpi: Opening database
*** LOG addons.xpi: Migrating data from extensions.rdf
*** LOG addons.xpi: Creating database schema
*** LOG addons.xpi: New add-on anonid0-annotator@jetpack installed in app-profile
*** LOG addons.xpi: Loading bootstrap scope from /var/folders/bN/bN4Z5w6UEdC60cFgLX32NU+++TI/-Tmp-/tmpom0YT6.mozrunner/extensions/anonid0-annotator@jetpack
*** LOG addons.xpi: Calling bootstrap method install on anonid0-annotator@jetpack version 1.3a0
*** LOG addons.xpi: New add-on {972ce4c6-7e08-4474-a285-3208198ce6fd} installed in app-global
*** LOG addons.xpi: Updating database with changes to installed add-ons
*** LOG addons.xpi: Updating add-on states
*** LOG addons.xpi: Writing add-ons list
*** LOG addons.xpi: Calling bootstrap method startup on anonid0-annotator@jetpack version 1.3a0
Running tests on Firefox 9.0a1/Gecko 9.0a1 ({ec8030f7-c20a-464f-9b0e-13a3a9e97384}) under Darwin/x86_64-gcc3.
.console: [JavaScript Warning: "reference to undefined property options.principal" {file: "resource://anonid0-annotator-at-jetpack-api-utils-lib/securable-module.js -> resource://anonid0-annotator-at-jetpack-api-utils-lib/securable-module.js" line: 135}]
warning: 1 warnings or errors were logged to the platform's nsIConsoleService, which could be of no consequence; however, they could also be indicative of aberrant behavior.
console: [JavaScript Warning: "reference to undefined property this._value" {file: "chrome://browser/content/urlbarBindings.xml" line: 634}]

1 of 1 tests passed.
OK
*** LOG addons.xpi: Calling bootstrap method shutdown on anonid0-annotator@jetpack version 1.3a0
*** LOG addons.xpi: shutdown
Total time: 1.916511 seconds
Program terminated successfully.


This verbosity is fine when the `--verbose` flag is set, but when it isn't, as by default, the command should not print such messages (nor others that it has been printing for a long time now; but that's a different bug).

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Remove related preference

I should not have land this preference at first place.
I don't think it could be usefull expect when you are debugging internal stuff in the sdk.
So here is a patch to remove the preference that enable all these messages.

Comment 2

[Alexandre Poirot [:ochameau]]

Landed:
https://github.com/mozilla/addon-sdk/commit/03877b509287f770f0e9f78a85697c148ba8bd24