68835 - table tab doesn't default for Table | Table Properties

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Kathleen :Brade]

When I pick Table Properties from the Table menu, I expect that the table tab
will be selected (not the cell tab).  This has regressed.

Charley--if you're too busy to look at this (though it should be really easy),
feel free to reassign it to me.

Comment 1

[Charles Manske]

This was changed on purpose, so when you are in a cell, you get Cell properties
tab. The only way you get the table tab is if the table is selected, so caret
(or selection) isn't inside the cell.
Maybe we should just make the menu string "Table and Cell Properties"?

Comment 2

[Kathleen :Brade]

hmmmmm... I thought we decided that the Table menu was to quickly access table 
properties (I can never remember how to select the whole table).  This also 
distinguishes this menu item from the Format menu's Table Cell Properties.

The table icon should be doing the "intelligent" stuff you are talking about 
above (select appropriate tab).

Comment 3

[Charles Manske]

Its very easy to switch to the "Table Tab" once in the dialog.
Would you favor keeping "Table Properties" and adding a special command just to
force it to start with "Table" tab?
What's wrong with changing text to "Table and Cell Properties"?

Comment 4

[Charles Manske]

Attachment: Fixes bug

Comment 5

[Charles Manske]

Attached fix reverts code in EditorInsertOrEditTable() to not start with Cell
properties tab. Then I pushed decision to start with Cell tab into
nsInsertOrEditTableCommand -- this is used by Table button on toolbar.
Kathy: please review.

Comment 6

[Kathleen :Brade]

r=brade

Comment 7

[Charles Manske]

Attachment: Also fixes "Table Properties" (cmd_editTable) menuitem not getting enabled correctly

Comment 8

[Charles Manske]

Kathy found above problem -- easily fixed: this is in the "oncreate" method for
the table menu. The menuitem's enable state wasn't being updated.
r=brade.

Comment 9

[Simon Fraser [no longer active]]

sr=sfraser

Comment 10

[Charles Manske]

checked in

Comment 11

[sujay]

verified in 2/22 build.