[Skia] Enable 'new AA' mode

RESOLVED FIXED in mozilla10

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

unspecified
mozilla10
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 561656 [details] [diff] [review]
Enable 'New AA' mode

I haven't looked exactly at what this does, but we fail some tests quite badly without it.

Stroking a vertical line was giving us AA artifacts. Bizarre.
Attachment #561656 - Flags: review?(jmuizelaar)
(In reply to Matt Woodrow (:mattwoodrow) from comment #0)
> Created attachment 561656 [details] [diff] [review]
> Enable 'New AA' mode
> 
> I haven't looked exactly at what this does, but we fail some tests quite
> badly without it.
> 
> Stroking a vertical line was giving us AA artifacts. Bizarre.

Does Chrome have the same problem?
(Assignee)

Comment 2

6 years ago
On windows, yes.

http://pastebin.mozilla.org/1334767 - Look for the small line of not-completely-green pixels
Comment on attachment 561656 [details] [diff] [review]
Enable 'New AA' mode

This is fine for now
Attachment #561656 - Flags: review?(jmuizelaar) → review+
We could also probably fix this by pixel aligning the line in the test case
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e59a560d237
Whiteboard: [inbound]

Updated

6 years ago
Assignee: nobody → matt.woodrow
https://hg.mozilla.org/mozilla-central/rev/7e59a560d237
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.