688456 - Report memory usage of Firefox and plugin-container separately in Talos

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Justin Lebar (not reading bugmail)]

Anode tells me that all our memory metrics on Talos report the sum of Firefox's and plugin-container's memory usage.

It seems to me that it would be more useful to report these two processes separately, since we control all of one process but little of the other.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

so would we want to report these as tp_rss_firefox, tp_rss_pluginprocess ?

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

tp_rss_flashprocess perhaps (if flash is the only plugin we use), but yes.

Comment 3

[cmtalbert]

Should we go ahead and generalize this to include content processes as well?  I think we're going to have to count content process memory sooner rather than later, so we might as well do it at the same time as this change.

Comment 4

[Justin Lebar (not reading bugmail)]

(In reply to Clint Talbert ( :ctalbert ) from comment #3)
> Should we go ahead and generalize this to include content processes as well?
> I think we're going to have to count content process memory sooner rather
> than later, so we might as well do it at the same time as this change.

sgtm!

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

I am handling this for osx in bug 693404.  We already do this for android.  Can we dup this bug, or should it be on for linux and windows?