Closed Bug 688505 Opened 10 years ago Closed 10 years ago

Use keyhole shape for back button on tablets


(Firefox for Android Graveyard :: General, defect)

Not set


(Not tracked)

Firefox 9


(Reporter: wesj, Assigned: wesj)



(Whiteboard: [inbound])


(3 files, 3 obsolete files)

We should use a keyhole here, like desktop does. See any of ians recent mockups:
Blocks: 655762
Attached patch WIP Patch (obsolete) — Splinter Review
Putting this up in case I don't have time to work on it anymore. Ian has some modified mockups coming soon.
Attached image More detailed mocks
Attached patch WIP2 (obsolete) — Splinter Review
Need to eat, but this is mostly done. I noticed that the buttons are showing highlights in disabled states, and need to use a correct color name. Build to play with is at:
Assignee: nobody → wjohnston
Attachment #561780 - Attachment is obsolete: true
Attached patch Patch v1 (obsolete) — Splinter Review
ian said he had some small comments coming. More worried about your response to using an svg clippath here. A sorta random svg-clip-path that I tweaked by hand to make look right...

The forward command has to listen to the urlbarstate broadcaster to pick up its mode on the forward button. Adding the observer to the forward button doesn't work.

Favicon switching is currently being done using a bgimage.

I also needed a new border color... grr..
Attachment #561859 - Attachment is obsolete: true
Attachment #561876 - Flags: review?(mark.finkle)
Attached image Updated urlbar mockup
More pixel-level detail feedback will be coming shortly, but after playing with this, Madhava and I realized that the second "tick" between the favicon and the page title feels a bit heavy handed. 

Let's remove second tick and move the title left, to where the tick is now.
Attached patch Patch v1.1Splinter Review
Removed left hand tick and shortened that lhs (and rhs) padding a bit.
Attachment #561876 - Attachment is obsolete: true
Attachment #561876 - Flags: review?(mark.finkle)
Attachment #561881 - Flags: review?(mark.finkle)
Comment on attachment 561881 [details] [diff] [review]
Patch v1.1

* color_default_default -> color_url_border
* revert the SSL colors and we will get them in the throbber bug

r+ but make those fixes
Attachment #561881 - Flags: review?(mark.finkle) → review+
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110925 Firefox/9.0a1 Fennec/9.0a1
Depends on: 691763
You need to log in before you can comment on or make changes to this bug.