688505 - Use keyhole shape for back button on tablets

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

We should use a keyhole here, like desktop does. See any of ians recent mockups:

http://www.flickr.com/photos/61892693@N03/6101561156/in/photostream

Comment 1

[Wesley Johnston (:wesj)]

Attachment: WIP Patch

Putting this up in case I don't have time to work on it anymore. Ian has some modified mockups coming soon.

Comment 2

[Ian Barlow (:ibarlow)]

Attachment: More detailed mocks

Comment 3

[Wesley Johnston (:wesj)]

Attachment: WIP2

Need to eat, but this is mostly done. I noticed that the buttons are showing highlights in disabled states, and need to use a correct color name. Build to play with is at:

http://people.mozilla.com/~wjohnston/fennec-fancyback.apk

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch v1

ian said he had some small comments coming. More worried about your response to using an svg clippath here. A sorta random svg-clip-path that I tweaked by hand to make look right...

The forward command has to listen to the urlbarstate broadcaster to pick up its mode on the forward button. Adding the observer to the forward button doesn't work.

Favicon switching is currently being done using a bgimage.

I also needed a new border color... grr..

Comment 5

[Ian Barlow (:ibarlow)]

Attachment: Updated urlbar mockup

More pixel-level detail feedback will be coming shortly, but after playing with this, Madhava and I realized that the second "tick" between the favicon and the page title feels a bit heavy handed. 

Let's remove second tick and move the title left, to where the tick is now.

Comment 6

[Wesley Johnston (:wesj)]

Attachment: Patch v1.1

Removed left hand tick and shortened that lhs (and rhs) padding a bit.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 561881 [details] [diff] [review]
Patch v1.1

* color_default_default -> color_url_border
* revert the SSL colors and we will get them in the throbber bug

r+ but make those fixes

Comment 8

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3e60b13624dc

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3e60b13624dc

Comment 10

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110925 Firefox/9.0a1 Fennec/9.0a1