68860 - selection should clear after selecting multiple rows/columns

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[sujay]

using 2/14 build of netscape

Charley and I both saw this in my cube

1) launch netscape
2) launch composer
3) enter 3 x 3 table
4) click on first cell
5) Shift-Ctrl + click and drag to select entire first row
6) then w/o letting go of mouse drag mouse downward to select
   the rest of the rows.
7) then let go of mouse
8) now click on first cell.
9) Try to select just the first cell: Shfit-Ctrl and click

you can't, it selects two whole columns giving you a selection 
you didn't ask for.

all platforms.

Comment 1

[Charles Manske]

Attachment: fix the bug

Comment 2

[Kathleen :Brade]

ok, this is a really tiny nitpick...
in the first part of your patch, you have "if (!mSelectingTableCells)" and then 
the next thing you do after the if block is set it to false; that assignment 
could be moved into an else block

more important though... how about a comment or two for the other parts of your 
patch?  :-)

r=brade

Comment 3

[Charles Manske]

This method (HandleTableSelection) is rather complicated and reasonably well
commented. The other small changes make sense in their contexts and I didn't
feel they needed extra comments.
I added the "else" as you suggested:

 if (!mSelectingTableCells)
   mAppendStartSelectedCell = nsnull;
 else
   mSelectingTableCells = PR_FALSE;

Comment 4

[Simon Fraser [no longer active]]

sr=sfraser

Comment 5

[Charles Manske]

checked in

Comment 6

[sujay]

verified in 2/22 build.