688651 - Add support of android devices to cfx

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

Having a builtin support of android device in cfx would help us ensure that all our development are really working on a real device.
It will help working on feature that can't be tested on Fennec for desktop, like complex touch events, geolocation & all.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 240

This patch adds two cfx options:
  cfx -a fennec-on-device
  cfx --mobile-app firefox_beta

We already have cfx -a fennec, that search for fennec binaries on your system.
Now we have fennec-on-device that launch tests or the addon directly on your connected android device.
When using this option, -b/--binary becomes mandatory and refer to your ADB executable.
(adb is the main command line tool to interact with android devices)

Then, I had to add --mobile-app option that expect an "intent" name. You may have installed multiple firefox version on your device. This option allows you to select which one you want to use: firefox, firefox_beta or firefox_nightly.

For now, this patch doesn't handle stdout so that you won't see console.logs nor test results on your command line. But you can manually check logs in the jsconsole.

Comment 2

[Brian Warner [:warner :bwarner]]

I added a few questions to the pull request.. looks mostly good, but I'd like to resolve those two before landing.

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 561928 [details]
Pull request 240

I just pushed a new commit and added some comment in the pull request.

Comment 4

[Brian Warner [:warner :bwarner]]

Comment on attachment 561928 [details]
Pull request 240

ok, as of commit f2a1ec2c it looks good to me. r+

Comment 5

[Alexandre Poirot [:ochameau]]

Landed:
https://github.com/mozilla/addon-sdk/commit/1caff283e90eacff1ab34ae4eda8f6dfb4901325