Closed Bug 688699 Opened 9 years ago Closed 6 years ago

neednom.com - drum circles demo doesn't work | "onplay" is not a function

Categories

(Web Compatibility :: Desktop, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: jdm, Unassigned)

References

()

Details

Presumably this is fallout from the onfoo moving to IDL change.
Specifically, pressing the play button does nothing in trunk. It's got an onclick="onplay()" attribute that throws the error in the summary.
onplay is defined in beat_circles.js.
Ah, the hazards of inline event handlers...  Don't use those!

Yes, this is a change from the onfoo moving to IDL change.  It's also behavior required by the spec.

The page was already broken in other browsers that had the on* properties present on elements, so I think the right thing to do here is to fix the page.
To be precise, bareword lookup in inline event handlers starts on the element, then goes up to either the form (for form controls) then the document, or just up to the document.  Only after that are properties on the window (which is what the onplay function defined in beat_circles.js is) looked at.

So the page can be fixed by using onclick="window.onplay()", using some other function name, or not using an inline event handler.
Assignee: nobody → english-us
Component: DOM → English US
Product: Core → Tech Evangelism
QA Contact: general → english-us
Version: Trunk → unspecified
There's also some kind of (potentially bogus) browser-sniffing going on there, but I didn't investigate all that thoroughly. When visiting the page with a recent Camino nightly, I got a warning that it "required Firefox".

Contact info here:

http://b3nf.com/me/index.html

and there's an e-mail address in the résumé PDF file.

cl
OS: Mac OS X → All
Hardware: x86 → All
Summary: drum circles demo doesn't work | "onplay" is not a function → neednom.com - drum circles demo doesn't work | "onplay" is not a function
→ ping www.neednom.com
ping: cannot resolve www.neednom.com: Unknown host
Assignee: english-us → nobody
Status: NEW → RESOLVED
Closed: 6 years ago
Component: English US → Desktop
Resolution: --- → INVALID
Product: Tech Evangelism → Web Compatibility
You need to log in before you can comment on or make changes to this bug.