Closed Bug 688740 Opened 13 years ago Closed 6 years ago

On Try, Talos and tests are consistently not run on Windows for pushes with try syntax on second line

Categories

(Release Engineering :: General, defect, P3)

x86
Windows XP
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: justin.lebar+bug, Unassigned, Mentored)

References

Details

(Keywords: trychooser, Whiteboard: [tryserver])

https://tbpl.mozilla.org/?tree=Try&rev=718f3d42eef3
https://tbpl.mozilla.org/?tree=Try&rev=ae42d72ec2e3
https://tbpl.mozilla.org/?tree=Try&rev=816e46867ee0
Bug 687767

These all did not get Windows Talos coverage, although the Windows builds are green.

I don't really need these jobs kicked, but I am a bit concerned that the failure rate for kicking Windows Talos is so high.
https://tbpl.mozilla.org/?tree=Try shows plenty of Windows Talos runs.
I'm wondering if this is a bug having to do with the talos comment on the not-first-line ?
(In reply to Aki Sasaki [:aki] from comment #1)
> https://tbpl.mozilla.org/?tree=Try shows plenty of Windows Talos runs.
> I'm wondering if this is a bug having to do with the talos comment on the
> not-first-line ?

I don't think so, he wouldn't be getting his other talos runs triggered by his syntax if that was the case.

https://tbpl.mozilla.org/?tree=Try&rev=df96c81d47cf shows talos runs successfully on win opt. Difference there is try: -b do and -u all where you've been using -b o and -u none.  I can test if there is something specific to windows that is affected by those syntax changes.  

Please report back if anything changes in the reproducibility of this bug that might help debug it.
Assignee: nobody → lsblakk
Priority: -- → P3
Tests are apparently also not run.  See

https://tbpl.mozilla.org/?tree=Try&rev=37ee26bb0b39
Summary: On Try, Talos is consistently not running on Windows for my pushes → On Try, Talos and tests are consistently not run on Windows for my pushes
Justin, out of curiousity can you do your try syntax in the first line of the commit just to eliminate that from being the issue?
(In reply to Lukas Blakk [:lsblakk] from comment #4)
> Justin, out of curiousity can you do your try syntax in the first line of
> the commit just to eliminate that from being the issue?

(or part of it) it can't be the whole issue since obviously enough syntax is being grabbed to limit your run to windows in the first place.
Sure; I pushed https://tbpl.mozilla.org/?tree=Try&rev=e3d9ef9907c7 with the try syntax on the first line.
Oops, I pushed the wrong patch last time.  This one should be better: https://tbpl.mozilla.org/?tree=Try&rev=dea870702047

(I didn't use the tryserver in-bug notification mechanism in case that somehow affects things.)
That push, with the try syntax on the first line, did run the mochitests.
Summary: On Try, Talos and tests are consistently not run on Windows for my pushes → On Try, Talos and tests are consistently not run on Windows for pushes with try syntax on second line
I wonder if this is an \r\n vs \n issue.
That would kind of suck, but would hopefully be easy to solve.
Unassigning and putting this to a mentored bug, I've been working with Eric Wong (new contributor) on this and will continue to do so.
Assignee: lsblakk → nobody
Component: Release Engineering → Release Engineering: Developer Tools
QA Contact: release → lsblakk
Whiteboard: [tryserver][mentor=lsblakk]
QA Contact: lsblakk → hwine
Keywords: trychooser
Product: mozilla.org → Release Engineering
is this bug still an issue?  Over the last couple months I have done dozens of try pushes with various options including selective tests, selective platforms and all.  In each case I have seen all my tests scheduled and ran (when machines are available)
Do you push with the try syntax on the second line of a commit message created with an editor that uses Windows line endings?
I do not, this is what I get for seeing a bug while searching for another and not parsing it correctly.  Thanks for setting me straight :philor
Mentor: lsblakk
Whiteboard: [tryserver][mentor=lsblakk] → [tryserver]
Component: Tools → General
Try chooser is dead and/or dying because of "./mach try fuzzy", WONTFIX!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.