68875 - Compacting of POP inbox does not work.

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P1)

Description

[Navin Gupta]

I am having problems with compaction of pop inbox folder. Most of the times it 
is not able to delete the old inbox file and so the "nstmp" cannot be renamed to 
new inbox. This is not happening with inbox.msf. It also happens with compaction 
of only inbox folder. 

This may be serious because if you shut down mail client and bring it up again, 
then nstmp shows up as a new folder. Also the old inbox is still getting used. 

This also happens with 02/06/01 opt build on windows.

I am not able to find if a bug has already been logged for this.

Comment 1

[scottputterman]

We need to be able to compact POP folders. Marking nsbeta1+ and moving to mozilla0.9

Comment 2

[Oliver Klee]

Bugs 66817, 66795 and 68837 look related.

Comment 3

[scottputterman]

It sounds like this is a dup of 65630.

Comment 4

[(not reading, please use [e-mail] instead)]

naving, will you attach your patch here?

Comment 5

[Navin Gupta]

Attachment: proposed fix. sr =sspitzer, bienvenu

Comment 6

[Navin Gupta]

fixed as a result of fixing #69862

Comment 7

[Navin Gupta]

checked in the fix for a memory leak. The other part of the fix was dependent
on #69862

Comment 8

[Sheela Ravindran]

change qa contact->myself, cc esther

Comment 9

[Navin Gupta]

#69862 has been backed out. So reopening 

Comment 10

[Navin Gupta]

*** Bug 70321 has been marked as a duplicate of this bug. ***

Comment 11

[Navin Gupta]

fixed as a result of fixing #69862

Comment 12

[Navin Gupta]

#69862 is backed out.

Comment 13

[Navin Gupta]

Attachment: revised patch since #69862 does not apply in all cases

Comment 14

[Navin Gupta]

Some of these changes in mailnews/local have already been reviewed. Only 
mailnews/base/search needs to be reviewed. #69862 was about closing streams in
dtor and it seems that it is not possible to do so because it breaks other 
components. 

cc bienvenu for review.

Comment 15

[David :Bienvenu]

Did you try a body search of a local mail folder and see that it turned up the
appropriate hits? It looks ok in general. Adding seth to cc list.

Comment 16

[Navin Gupta]

Yup, body search works fine but I will do some more testing on mac.

Comment 17

[Navin Gupta]

fix checked in

Comment 18

[Sheela Ravindran]

verified,
win98-2001-03-23-06
linux-2001-03-23-05
mac-2001-03-23-10