Move file menu from editorOverlay to editingOverlay

RESOLVED FIXED in seamonkey2.7

Status

SeaMonkey
Composer
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.7
Dependency tree / graph
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.7 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

7 years ago
Created attachment 562048 [details] [diff] [review]
Share file menu

At the moment Messenger Compose has a separate file menu to the one for Composer and Plain Text Editor.
This continues the work started in bug 680805 and use two overlays:
* editingOverlay.xul for code that is only used in both Composer and Plain Text Editor and can be moved out of editorOverlay.xul
* mailComposeOverlay.xul for code that needs to be added on top of editorOverlay.xul for messengercompose.xul

This will allow for the file menu to be shared from editorOverlay.xul for all of Composer, Plain Text Editor and Messenger Compose.

This patch:
* Updates editingOverlay.xul and moves Composer/Plain Text Editor specific keysets, commandsets and menu items to it from editorOverlay.xul
* Creates editingOverlay.js and moves Composer/Plain Text Editor specific js code to it from editor.js
* Updates editingOverlay.dtd and moves relevant entities from editorOverlay.dtd
* Updates references to file menu/menuitems in editor.xul and composerOverlay.xul
* Updates mailComposeOverlay.xul and moves messsage compose specific keysets, commandsets, menu items and toolbar buttons to it from messengercompose.xul
* Creates mailComposeOverlay.dtd and moves relevant entities to it from messengercompose.dtd
Attachment #562048 - Flags: review?(neil)

Comment 1

7 years ago
It doesn't seem as if there are enough shared items to make this worthwhile?
(Assignee)

Updated

7 years ago
Summary: Share file menus between Composer, Plain Text Editor and Messenger Compose → Move file menu from editorOverlay to editingOverlay
(Assignee)

Comment 2

7 years ago
Created attachment 562197 [details] [diff] [review]
Move file menu

This patch:
* Moves file menu xul code from editorOverlay.xul to editingOverlay.xul as it is only used by Composer/Plain Text Editor.
* Moves associated entities from editorOverlay.dtd to editingOverlay.dtd
* Creates editingOverlay.js and moves js code only used by Composer/Plain Text Editor file menu to it.
* Some tidy up in messengercompose.xul
Attachment #562048 - Attachment is obsolete: true
Attachment #562048 - Flags: review?(neil)
Attachment #562197 - Flags: review?(neil)

Comment 3

7 years ago
Comment on attachment 562197 [details] [diff] [review]
Move file menu

>+  <commandset id="composerSaveMenuItems">
Not sure what the point of adding this commandset to messengercompose.xul is, it would live perfectly happily in editingOverlay.xul as far as I could see.

(Haven't actually tested this because I don't have the right dependent patch(es) applied but the rest of the patch looks reasonable to me.)
(Assignee)

Comment 4

7 years ago
Created attachment 562580 [details] [diff] [review]
Move file menu with less moving

Changes since last version:
* Removed save commandset from messengercompose.xul
* Fixed issue with changed name for save menu item in editingOverlay.js
Attachment #562197 - Attachment is obsolete: true
Attachment #562197 - Flags: review?(neil)
Attachment #562580 - Flags: review?(neil)

Comment 5

7 years ago
Comment on attachment 562580 [details] [diff] [review]
Move file menu with less moving

>diff --git a/suite/mailnews/compose/messengercompose.xul b/suite/mailnews/compose/messengercompose.xul
These changes no longer relate to this bug. r=me on the rest of the changes.
Attachment #562580 - Flags: review?(neil) → review+
(Assignee)

Comment 6

7 years ago
Created attachment 562867 [details] [diff] [review]
Move file menu without messengercompose [Checked in: Comment 8]

Changes since last version:
* Removed messengercompose.xul changes as suggested.
Attachment #562580 - Attachment is obsolete: true
Attachment #562867 - Flags: review+
(Assignee)

Comment 7

7 years ago
Comment on attachment 562867 [details] [diff] [review]
Move file menu without messengercompose [Checked in: Comment 8]

Requesting additional TB review for changes to shared code.
Attachment #562867 - Flags: review?(mbanner)
(Assignee)

Updated

7 years ago
Blocks: 690145
(Assignee)

Updated

6 years ago
Blocks: 695842
Attachment #562867 - Flags: review?(mbanner) → review+
(Assignee)

Comment 8

6 years ago
Comment on attachment 562867 [details] [diff] [review]
Move file menu without messengercompose [Checked in: Comment 8]

http://hg.mozilla.org/comm-central/rev/b5ccd380ba51
Attachment #562867 - Attachment description: Move file menu without messengercompose → Move file menu without messengercompose [Checked in: Comment 8]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-seamonkey2.7: --- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.7
You need to log in before you can comment on or make changes to this bug.