Closed Bug 688782 Opened 13 years ago Closed 12 years ago

Clear up !important in css

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: sriram, Unassigned)

References

Details

(Keywords: helpwanted, Whiteboard: [mentor=sriram@mozilla.com][good first bug])

Attachments

(1 file)

Initial patch for bug 688782.
154.85 KB, patch
sriram
: review-
Details | Diff | Splinter Review 
The 3 themes have many !important.
It is confusing to add any rule to existing ones.
It is better to clear the !important's.
Keywords: helpwanted
Whiteboard: [mentor=sriram@mozilla.com][good first bug]
Attachment #566508 - Flags: superreview?(lucasr.at.mozilla)
The idea of the bug is not to remove all "!important" in all rules. It is to look into "!important" in the rules and see which ones are needed and which ones aren't and remove those ones. Hence, we cannot use this patch.
Attachment #566508 - Flags: review?(sriram) → review-
Oh, sorry. I'll fix it.

Thanks Sriram!
Sriram, is this still a valid bug for a new contributor to be working on? In other words, does this still apply to the Native UI, so that the work done won't be wasted?
(In reply to Josh Matthews [:jdm] from comment #4)
> Sriram, is this still a valid bug for a new contributor to be working on? In
> other words, does this still apply to the Native UI, so that the work done
> won't be wasted?

It is better recommended not to work on this bug. This doesn't affect Native UI anymore.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Attachment #566508 - Flags: superreview?(lucasr.at.mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: