688824 - Hide restart if locale is changed to current locale

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Using the new locale picker in preferences, we currently show the restart notification any time the locale pref changes. We should be smarter and hide the restart notification if the user changes their locale back.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch v1

This fixes the preferencesView store the current locale and checking against it on updates. I also removed a check in localePicker.js. This is an easy fix to a bigger problem in there. If you click on a langaugePack row we do not update LocaleUI._locale. When you then click back on English, we think it is the current locale and don't bother updating the ui (or any restart notifications that were set).

I'm putting my "This needs tests!" hat back on, and holding off on review until I've done that.

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

I've moved the piece that was failing because we don't update the LocaleUI.locale when switching from downloaded locales to already installed locales in the tests (bug 684241), along with some questions about whether we want it or not.

Comment 6

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/077a86b75bdb

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/077a86b75bdb

Comment 8

[Aaron Train [:aaronmt]]

aurora nom?

Comment 9

[Cristian Nicolae (:xti)]

(In reply to Aaron Train [:aaronmt] from comment #8)
> aurora nom?

Yes. This issue is still reproducing on the latest Aurora build and I guess that it should be fixed before FF9 will merge to Beta. If a user will tap on a different locale and then will change his/her mind by tapping on the Cancel button, a Restart app is requested. So the last selected language pack will be applied, even if in fact, the action was canceled.

Comment 10

[u279076]

Does this affect mobile-only?

Comment 11

[Matt Brubeck (:mbrubeck)]

(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #10)
> Does this affect mobile-only?

Yes.

Comment 12

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:10.0)Gecko/20111228
Firefox/10.0 Fennec/10.0
Devices: Samsung Galaxy S
OS: Android 2.2