Hide restart if locale is changed to current locale

VERIFIED FIXED in Firefox 10

Status

Fennec Graveyard
General
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: wesj, Assigned: wesj)

Tracking

(Blocks: 1 bug, {polish})

Trunk
Firefox 10
polish
Dependency tree / graph

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Using the new locale picker in preferences, we currently show the restart notification any time the locale pref changes. We should be smarter and hide the restart notification if the user changes their locale back.
(Assignee)

Updated

6 years ago
Depends on: 658278

Updated

6 years ago
Keywords: polish

Updated

6 years ago
Duplicate of this bug: 689542
(Assignee)

Comment 2

6 years ago
Created attachment 562830 [details] [diff] [review]
Patch v1

This fixes the preferencesView store the current locale and checking against it on updates. I also removed a check in localePicker.js. This is an easy fix to a bigger problem in there. If you click on a langaugePack row we do not update LocaleUI._locale. When you then click back on English, we think it is the current locale and don't bother updating the ui (or any restart notifications that were set).

I'm putting my "This needs tests!" hat back on, and holding off on review until I've done that.
Assignee: nobody → wjohnston
(Assignee)

Updated

6 years ago
Blocks: 689706
Duplicate of this bug: 690407
(Assignee)

Comment 4

6 years ago
Created attachment 563509 [details] [diff] [review]
Patch

I've moved the piece that was failing because we don't update the LocaleUI.locale when switching from downloaded locales to already installed locales in the tests (bug 684241), along with some questions about whether we want it or not.
Attachment #563509 - Flags: review?(mark.finkle)
Attachment #563509 - Flags: review?(mark.finkle) → review+
Duplicate of this bug: 665514
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/077a86b75bdb
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/077a86b75bdb
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 10
status-firefox10: --- → fixed
status-firefox9: --- → affected
tracking-firefox9: --- → ?
aurora nom?
tracking-firefox9: ? → ---
(In reply to Aaron Train [:aaronmt] from comment #8)
> aurora nom?

Yes. This issue is still reproducing on the latest Aurora build and I guess that it should be fixed before FF9 will merge to Beta. If a user will tap on a different locale and then will change his/her mind by tapping on the Cancel button, a Restart app is requested. So the last selected language pack will be applied, even if in fact, the action was canceled.
Whiteboard: [qa+]
Does this affect mobile-only?
Whiteboard: [qa+]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #10)
> Does this affect mobile-only?

Yes.
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:10.0)Gecko/20111228
Firefox/10.0 Fennec/10.0
Devices: Samsung Galaxy S
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.