cairo_surface_wrapper_flush function incomplete

UNCONFIRMED
Unassigned

Status

()

Core
Graphics
UNCONFIRMED
7 years ago
7 years ago

People

(Reporter: Mark Straver, Unassigned)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
Compiling Firefox from source on Windows I noticed a warning thrown by MSVC during the PGO linking phase:
c:\mozdev\src\gfx\cairo\cairo\src\cairo-surface-wrapper.c(720) : warning C4715: '_cairo_surface_wrapper_flush' : not all control paths return a value

The function in question is:
cairo_status_t
_cairo_surface_wrapper_flush (cairo_surface_wrapper_t *wrapper)
{
    if (wrapper->target->backend->flush) {
	return wrapper->target->backend->flush(wrapper->target);
    }
}

This seems to be incomplete because when the if statement is false, the function doesn't return anything, leaving the state undetermined -- was this intended? What will be done with the undetermined state? Is this a potential cause for instability?
(Reporter)

Updated

7 years ago
Summary: cairo_surface_wraper_flush function incomplete → cairo_surface_wrapper_flush function incomplete
You need to log in before you can comment on or make changes to this bug.