Closed Bug 689045 Opened 8 years ago Closed 8 years ago

Canvas Shadow swap/Init API rework

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: romaxa, Assigned: romaxa)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

Followup for bug 687372, canvas case.
We should remove mDeadWeight, and Init function and operate only with Swap API for canvas update
Attached patch Canvas Init/Swap API rework (obsolete) — Splinter Review
Quick fix for canvas Swap/Init API change
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #562312 - Flags: review?(jones.chris.g)
Comment on attachment 562312 [details] [diff] [review]
Canvas Init/Swap API rework

Looks OK, but why the move to SharedImage for canvas?  We're never
going to have a YUV surface backing canvas.  Let's stick with
SurfaceDescriptor.
Attachment #562312 - Flags: review?(jones.chris.g)
I've installed null_t for SharedImage union, and in order to make similar approach here, we need to add null_t to SurfaceDescriptor too... should I do that?
I think I'd be happier with a

 union CanvasSurface {
   SurfaceDescriptor;
   null_t;
 };

Thanks.
Attached patch Canvas Init/Swap API rework (obsolete) — Splinter Review
Use canvas surface
Attachment #562312 - Attachment is obsolete: true
Attachment #562665 - Flags: review?(jones.chris.g)
Attached patch Canvas Init/Swap API rework (obsolete) — Splinter Review
Ups, forgot qrefresh
Attachment #562665 - Attachment is obsolete: true
Attachment #562665 - Flags: review?(jones.chris.g)
Attachment #562666 - Flags: review?(jones.chris.g)
Comment on attachment 562666 [details] [diff] [review]
Canvas Init/Swap API rework

Looks good, thanks.
Attachment #562666 - Flags: review?(jones.chris.g) → review+
Attachment #562666 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/455bee36af33
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Blocks: 691417
Depends on: 695406
Depends on: 696013
You need to log in before you can comment on or make changes to this bug.