689045 - Canvas Shadow swap/Init API rework

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

Followup for bug 687372, canvas case.
We should remove mDeadWeight, and Init function and operate only with Swap API for canvas update

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Canvas Init/Swap API rework

Quick fix for canvas Swap/Init API change

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 562312 [details] [diff] [review]
Canvas Init/Swap API rework

Looks OK, but why the move to SharedImage for canvas?  We're never
going to have a YUV surface backing canvas.  Let's stick with
SurfaceDescriptor.

Comment 3

[Oleg Romashin (:romaxa)]

I've installed null_t for SharedImage union, and in order to make similar approach here, we need to add null_t to SurfaceDescriptor too... should I do that?

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I think I'd be happier with a

 union CanvasSurface {
   SurfaceDescriptor;
   null_t;
 };

Thanks.

Comment 5

[Oleg Romashin (:romaxa)]

Attachment: Canvas Init/Swap API rework

Use canvas surface

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: Canvas Init/Swap API rework

Ups, forgot qrefresh

Comment 7

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 562666 [details] [diff] [review]
Canvas Init/Swap API rework

Looks good, thanks.

Comment 8

[Oleg Romashin (:romaxa)]

Attachment: Canvas Init/Swap API rework. to push

Comment 9

[Oleg Romashin (:romaxa)]

https://tbpl.mozilla.org/?tree=Try&rev=3c11a4c84212

Comment 10

[Oleg Romashin (:romaxa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/455bee36af33

Comment 11

[Michael Wu [:mwu]]

https://hg.mozilla.org/mozilla-central/rev/455bee36af33