The default bug view has changed. See this FAQ.

Canvas Shadow swap/Init API rework

RESOLVED FIXED in mozilla10

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

(Blocks: 1 bug)

Trunk
mozilla10
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

6 years ago
Followup for bug 687372, canvas case.
We should remove mDeadWeight, and Init function and operate only with Swap API for canvas update
(Assignee)

Comment 1

6 years ago
Created attachment 562312 [details] [diff] [review]
Canvas Init/Swap API rework

Quick fix for canvas Swap/Init API change
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #562312 - Flags: review?(jones.chris.g)
Comment on attachment 562312 [details] [diff] [review]
Canvas Init/Swap API rework

Looks OK, but why the move to SharedImage for canvas?  We're never
going to have a YUV surface backing canvas.  Let's stick with
SurfaceDescriptor.
Attachment #562312 - Flags: review?(jones.chris.g)
(Assignee)

Comment 3

6 years ago
I've installed null_t for SharedImage union, and in order to make similar approach here, we need to add null_t to SurfaceDescriptor too... should I do that?
I think I'd be happier with a

 union CanvasSurface {
   SurfaceDescriptor;
   null_t;
 };

Thanks.
(Assignee)

Comment 5

6 years ago
Created attachment 562665 [details] [diff] [review]
Canvas Init/Swap API rework

Use canvas surface
Attachment #562312 - Attachment is obsolete: true
Attachment #562665 - Flags: review?(jones.chris.g)
(Assignee)

Comment 6

6 years ago
Created attachment 562666 [details] [diff] [review]
Canvas Init/Swap API rework

Ups, forgot qrefresh
Attachment #562665 - Attachment is obsolete: true
Attachment #562665 - Flags: review?(jones.chris.g)
Attachment #562666 - Flags: review?(jones.chris.g)
Comment on attachment 562666 [details] [diff] [review]
Canvas Init/Swap API rework

Looks good, thanks.
Attachment #562666 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 8

6 years ago
Created attachment 563138 [details] [diff] [review]
Canvas Init/Swap API rework. to push
Attachment #562666 - Attachment is obsolete: true
(Assignee)

Comment 9

6 years ago
https://tbpl.mozilla.org/?tree=Try&rev=3c11a4c84212
(Assignee)

Comment 10

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/455bee36af33

Comment 11

6 years ago
https://hg.mozilla.org/mozilla-central/rev/455bee36af33
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
(Assignee)

Updated

6 years ago
Blocks: 691417
(Assignee)

Updated

6 years ago
Depends on: 695406
(Assignee)

Updated

6 years ago
Depends on: 696013
You need to log in before you can comment on or make changes to this bug.