Last Comment Bug 689045 - Canvas Shadow swap/Init API rework
: Canvas Shadow swap/Init API rework
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla10
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on: 695406 696013
Blocks: 691417
  Show dependency treegraph
 
Reported: 2011-09-25 11:46 PDT by Oleg Romashin (:romaxa)
Modified: 2011-10-20 14:17 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Canvas Init/Swap API rework (24.22 KB, patch)
2011-09-25 11:48 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Review
Canvas Init/Swap API rework (24.22 KB, patch)
2011-09-26 23:25 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Review
Canvas Init/Swap API rework (25.38 KB, patch)
2011-09-26 23:36 PDT, Oleg Romashin (:romaxa)
cjones.bugs: review+
Details | Diff | Review
Canvas Init/Swap API rework. to push (25.45 KB, patch)
2011-09-28 12:14 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Review

Description Oleg Romashin (:romaxa) 2011-09-25 11:46:57 PDT
Followup for bug 687372, canvas case.
We should remove mDeadWeight, and Init function and operate only with Swap API for canvas update
Comment 1 Oleg Romashin (:romaxa) 2011-09-25 11:48:17 PDT
Created attachment 562312 [details] [diff] [review]
Canvas Init/Swap API rework

Quick fix for canvas Swap/Init API change
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-09-26 17:27:12 PDT
Comment on attachment 562312 [details] [diff] [review]
Canvas Init/Swap API rework

Looks OK, but why the move to SharedImage for canvas?  We're never
going to have a YUV surface backing canvas.  Let's stick with
SurfaceDescriptor.
Comment 3 Oleg Romashin (:romaxa) 2011-09-26 17:29:01 PDT
I've installed null_t for SharedImage union, and in order to make similar approach here, we need to add null_t to SurfaceDescriptor too... should I do that?
Comment 4 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-09-26 17:31:30 PDT
I think I'd be happier with a

 union CanvasSurface {
   SurfaceDescriptor;
   null_t;
 };

Thanks.
Comment 5 Oleg Romashin (:romaxa) 2011-09-26 23:25:43 PDT
Created attachment 562665 [details] [diff] [review]
Canvas Init/Swap API rework

Use canvas surface
Comment 6 Oleg Romashin (:romaxa) 2011-09-26 23:36:48 PDT
Created attachment 562666 [details] [diff] [review]
Canvas Init/Swap API rework

Ups, forgot qrefresh
Comment 7 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-09-27 00:07:41 PDT
Comment on attachment 562666 [details] [diff] [review]
Canvas Init/Swap API rework

Looks good, thanks.
Comment 8 Oleg Romashin (:romaxa) 2011-09-28 12:14:21 PDT
Created attachment 563138 [details] [diff] [review]
Canvas Init/Swap API rework. to push
Comment 9 Oleg Romashin (:romaxa) 2011-09-28 12:15:12 PDT
https://tbpl.mozilla.org/?tree=Try&rev=3c11a4c84212
Comment 11 Michael Wu [:mwu] 2011-09-29 01:33:04 PDT
https://hg.mozilla.org/mozilla-central/rev/455bee36af33

Note You need to log in before you can comment on or make changes to this bug.