Closed Bug 689046 Opened 10 years ago Closed 10 years ago

createPattern(zero-size canvas) should throw

Categories

(Core :: Canvas: 2D, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

()

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Attached patch Patch v1Splinter Review
Azure already does this, regular doesn't.
Attachment #562315 - Flags: review?(roc)
Flags: in-testsuite+
Comment on attachment 562315 [details] [diff] [review]
Patch v1

Review of attachment 562315 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good, but why not use "is" in the tests?
The test is auto-generated from the same source as the W3C test, and I'd rather keep our copy as close as possible to that, to make it easier to update (which I happen to be working on atm).

Also, is() uses == instead of ===, which I guess is fine in this case, but I wouldn't want to change that in the general case.
https://hg.mozilla.org/mozilla-central/rev/3b303c61a49a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.