Last Comment Bug 689046 - createPattern(zero-size canvas) should throw
: createPattern(zero-size canvas) should throw
: dev-doc-complete
Product: Core
Classification: Components
Component: Canvas: 2D (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla10
Assigned To: :Ms2ger (⌚ UTC+1/+2)
: Milan Sreckovic [:milan]
Depends on:
Blocks: 622842
  Show dependency treegraph
Reported: 2011-09-25 12:10 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-12-09 10:01 PST (History)
2 users (show)
Ms2ger: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (4.47 KB, patch)
2011-09-25 12:10 PDT, :Ms2ger (⌚ UTC+1/+2)
roc: review+
Details | Diff | Splinter Review

Description User image :Ms2ger (⌚ UTC+1/+2) 2011-09-25 12:10:38 PDT
Created attachment 562315 [details] [diff] [review]
Patch v1

Azure already does this, regular doesn't.
Comment 1 User image Robert O'Callahan (:roc) (email my personal email if necessary) 2011-09-25 14:35:50 PDT
Comment on attachment 562315 [details] [diff] [review]
Patch v1

Review of attachment 562315 [details] [diff] [review]:

Code looks good, but why not use "is" in the tests?
Comment 2 User image :Ms2ger (⌚ UTC+1/+2) 2011-09-25 23:21:07 PDT
The test is auto-generated from the same source as the W3C test, and I'd rather keep our copy as close as possible to that, to make it easier to update (which I happen to be working on atm).

Also, is() uses == instead of ===, which I guess is fine in this case, but I wouldn't want to change that in the general case.
Comment 3 User image :Ms2ger (⌚ UTC+1/+2) 2011-10-02 03:01:03 PDT
See comment 2
Comment 4 User image :Ms2ger (⌚ UTC+1/+2) 2011-10-08 08:09:21 PDT
Comment 5 User image Eric Shepherd [:sheppy] 2011-12-09 10:01:34 PST
Documentation updated:

And mentioned on Firefox 10 for developers.

Note You need to log in before you can comment on or make changes to this bug.