createPattern(zero-size canvas) should throw

RESOLVED FIXED in mozilla10

Status

()

Core
Canvas: 2D
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

Trunk
mozilla10
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 562315 [details] [diff] [review]
Patch v1

Azure already does this, regular doesn't.
Attachment #562315 - Flags: review?(roc)
Flags: in-testsuite+
(Assignee)

Updated

6 years ago
Comment on attachment 562315 [details] [diff] [review]
Patch v1

Review of attachment 562315 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good, but why not use "is" in the tests?
(Assignee)

Comment 2

6 years ago
The test is auto-generated from the same source as the W3C test, and I'd rather keep our copy as close as possible to that, to make it easier to update (which I happen to be working on atm).

Also, is() uses == instead of ===, which I guess is fine in this case, but I wouldn't want to change that in the general case.
(Assignee)

Comment 3

6 years ago
See comment 2
Attachment #562315 - Flags: review?(roc) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/3b303c61a49a
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
(Assignee)

Updated

6 years ago
Keywords: dev-doc-needed
Documentation updated:

https://developer.mozilla.org/en/DOM/CanvasRenderingContext2D#createPattern%28%29
https://developer.mozilla.org/en/Canvas_tutorial/Applying_styles_and_colors#Patterns

And mentioned on Firefox 10 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.