When upgrading Thunderbird, the button in the installer should be "Upgrade" instead of "Install" (Port bug 508684)

NEW
Assigned to

Status

--
minor
7 years ago
2 years ago

People

(Reporter: LpSolit, Assigned: myopensourcework, Mentored)

Tracking

7 Branch

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
When you upgrade Firefox, the installer has a button named "Upgrade" instead of "Install". The Thunderbird installer should do the same, as it's really going to upgrade your existing application. I'm talking about the last button being displayed in the installer right before upgrading your application.
Ah, good idea, I hadn't noticed Firefox did this in bug 508684.
See Also: → bug 508684
Summary: When upgrading Thunderbird, the button in the installer should be "Upgrade" instead of "Install" → When upgrading Thunderbird, the button in the installer should be "Upgrade" instead of "Install" (Port bug 508684)

Comment 2

3 years ago
This finally annoyed me enough to come file a bug report for it and found out someone beat me to it a long time ago...

I'll go send an email to the support list and see if someone can pick this up and fix it...

Updated

3 years ago
Severity: enhancement → minor
Whiteboard: [good first bug]

Updated

3 years ago
Mentor: mkmelin+mozilla

Comment 3

3 years ago
Created attachment 8648584 [details] [diff] [review]
Fixed the bug by emulating the changes to made to files under the folder browser/ in bug 508684 to the files under mail/
Attachment #8648584 - Flags: review?(mkmelin+mozilla)

Comment 4

3 years ago
Comment on attachment 8648584 [details] [diff] [review]
Fixed the bug by emulating the changes to made to files under the folder browser/ in bug 508684 to the files under mail/

Review of attachment 8648584 [details] [diff] [review]:
-----------------------------------------------------------------

Looks almost ready!

Besides the problems below, please also remove any trailing whitespace your patch adds. (It's shown in red when you look at https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=689057&attachment=8648584)

::: mail/installer/windows/nsis/installer.nsi
@@ +936,5 @@
> +  ${Unless} ${Errors}
> +	DeleteRegValue HKLM "Software\Thunderbird" "${BrandShortName}InstallerTest"
> +	; Check if Firefox is already the handler for http. This is set on all
> +	; versions of Windows.
> +	${IsHandlerForInstallDir} "http" $R9

We don't want to be default browser.
The text in thunderbird should be about default mail client. And probably "mailto" instead of "http"

@@ +953,3 @@
>    ${If} "$TmpVal" == "true"
> +	; If there is already a Type entry in the "Field 4" section with a value of
> +	; checkbox then the set as the default browser checkbox is displayed and

mail client

::: mail/locales/en-US/installer/custom.properties
@@ +34,5 @@
>  SUMMARY_PAGE_SUBTITLE=Ready to start installing $BrandShortName
>  SUMMARY_INSTALLED_TO=$BrandShortName will be installed to the following location:
>  SUMMARY_REBOOT_REQUIRED_INSTALL=A restart of your computer may be required to complete the installation.
>  SUMMARY_REBOOT_REQUIRED_UNINSTALL=A restart of your computer may be required to complete the uninstall.
> +SUMMARY_TAKE_DEFAULTS=U&se $BrandShortName as my default web browser

default mail application
Attachment #8648584 - Flags: review?(mkmelin+mozilla) → review-
(Assignee)

Comment 5

3 years ago
Is it all right if I take over this bug? It looks like all this needs is some formatting stuff and a few corrections.

Comment 6

3 years ago
Sure!
Assignee: nobody → myopensourcework
(Assignee)

Comment 7

3 years ago
Created attachment 8712555 [details] [diff] [review]
Bug689057Fix.patch

Here you go Magnus, I have to admit i'm not terribly familiar with this language so please let me know if any of my attempts at correction either introduced or missed any errors!

Comment 8

2 years ago
Has this been reviewed and resolved?
You need to log in before you can comment on or make changes to this bug.