Last Comment Bug 689069 - [Skia] Forcibly disable frame pointer for ARM optimized functions
: [Skia] Forcibly disable frame pointer for ARM optimized functions
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla10
Assigned To: Matt Woodrow (:mattwoodrow)
:
Mentors:
Depends on:
Blocks: 687187
  Show dependency treegraph
 
Reported: 2011-09-25 16:24 PDT by Matt Woodrow (:mattwoodrow)
Modified: 2011-10-28 12:20 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Disable framepointers (1.90 KB, patch)
2011-09-25 16:24 PDT, Matt Woodrow (:mattwoodrow)
jmuizelaar: review+
Details | Diff | Splinter Review
Disable framepointers v2 (4.32 KB, patch)
2011-10-17 17:48 PDT, Matt Woodrow (:mattwoodrow)
matt.woodrow: review+
Details | Diff | Splinter Review

Description Matt Woodrow (:mattwoodrow) 2011-09-25 16:24:12 PDT
Created attachment 562339 [details] [diff] [review]
Disable framepointers

These functions are using registers that are reserved when the frame pointer is enabled. This patch forces it to be disabled just for these functions so that they actually build and run.
Comment 1 Matt Woodrow (:mattwoodrow) 2011-10-17 17:48:17 PDT
Created attachment 567637 [details] [diff] [review]
Disable framepointers v2

Added patch file, and updated update.sh.

Carrying forward r=jrmuizel
Comment 2 Matt Woodrow (:mattwoodrow) 2011-10-28 00:17:29 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a6b1c88a6ce
Comment 3 Matt Brubeck (:mbrubeck) 2011-10-28 12:20:41 PDT
https://hg.mozilla.org/mozilla-central/rev/7a6b1c88a6ce

Note You need to log in before you can comment on or make changes to this bug.