689251 - Unable to add Add-on Screenshot

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Ken Saunders]

Attachment: (thumbnail) image displayed after uploading

User Agent: Mozilla/5.0 (Windows NT 6.0; rv:9.0a1) Gecko/20110922 Firefox/9.0a1
Build ID: 20110922030907

Steps to reproduce:

When trying to add screenshots for an add-on (https://addons.mozilla.org/en-US/developers/addon/page-zoom-buttons/edit > Images > edit), the screenshot initially shows up after uploading one (Add a Screenshot...), but after clicking on Save Changes, all that is shown is a spinning throbber, and it is displayed infinitely. The screenshot is not shown on the add-on's public page, just a blank placeholder. 

This same issue occurred in two different AMO accounts, and with Firefox 6.0.2, and Nightly





Expected results:

Images should be displayed after saving changes

Comment 1

[Ken Saunders]

Attachment: Infinite throbber shown after saving changes in Images > edit

Comment 2

[Gregory Koberger (:gkoberger)]

Thanks Ken!  We had some trouble with celery (which we use for processing images) dropping jobs last week, but it's back to normal.  I'm not 100% sure that's the issue, but either way it seems to be working now.  Let me know if it still isn't working.

Comment 3

[Ken Saunders]

Sorry, still having the same issue, two different Firefox profiles/versions, cache cleared, etc.
I'm attaching one the images that I'm trying upload.
If you believe that it would be helpful, I'll grant direct access to my AMO account.

Comment 4

[Ken Saunders]

Attachment: Image for AMO add-on

Comment 5

[Gregory Koberger (:gkoberger)]

Okay, I'll try again :)

Comment 6

[Axel Grude [:realRaven]]

I have the same problem with 2 separate extensions (quickfolders and quickpasswords). The common thing is that I am uploading png files that were created with a very old version of Paintshop (PSPro 6.0). I will try uploading with Google chrome next. (Could this be server specific? then a new session should do it). Interestingly, earlier I uploaded the images and they looked fine on the Save page but never showed up on the Extension listing page.

Comment 7

[Axel Grude [:realRaven]]

I just tried converting the images into jpeg files, this seems to work. AMO will convert them to png files anyway, but the files will actually "stick" so that my extensions have screen shots again!

Comment 8

[Axel Grude [:realRaven]]

Attachment: one of the images that did not "stay"

png image, would not stay on the site

Comment 9

[Axel Grude [:realRaven]]

Attachment: same image, jpeg version works

the same image, uploaded as jpeg; this time the upload worked

Comment 10

[Ken Saunders]

Uploading jpeg formatted images does work.
Nice find Axel!

Of course it isn't a fix, but a workaround for sure.

Comment 11

[Jeff Balogh (:jbalogh)]

Thanks for debugging this Axel. Here's the error we log:

Oct  7 10:59:57 celery-dev1.addons.phx1.mozilla.com: [][] z.devhub.task:ERROR Error saving preview: cannot read interlaced PNG files/apps/devhub/tasks.py:211

Figuring out how to get this working is probably out of our scope.

Comment 12

[Axel Grude [:realRaven]]

(In reply to Jeff Balogh (:jbalogh) from comment #11)
> Thanks for debugging this Axel. Here's the error we log:
> 
> Oct  7 10:59:57 celery-dev1.addons.phx1.mozilla.com: [][]
> z.devhub.task:ERROR Error saving preview: cannot read interlaced PNG
> files/apps/devhub/tasks.py:211
> 
> Figuring out how to get this working is probably out of our scope.

Well that's good then (debugging is probably too good a word for this, though). Means if I can save the png as non-interlaced it might also work around the error. Need to check whether my aulde Photoshop or Gimp can do this...

Comment 13

[Gregory Koberger (:gkoberger)]

Seem like updating PIL to 1.1.7 [1] will fix this (see bug 695229) so I'm bumping it for now and will check back when the blocking bug is resolved.

1. https://bitbucket.org/effbot/pil-2009-raclette/src/tip/CHANGES#cl-95

Comment 14

[Gregory Koberger (:gkoberger)]

Still no updates, so I'm moving it out of this milestone.

Comment 15

[Wil Clouser [:clouserw]]

Can you test this on addons-dev.allizom.org?  It's using the newer PIL.

Comment 16

[Gregory Koberger (:gkoberger)]

This works, thanks Jeremy! We should be good to add it on prod.

Comment 17

[Gregory Koberger (:gkoberger)]

Anddd I added that comment to the wrong bug. Either way, though, it works on preview and will trickle down to prod.

Comment 18

[Wil Clouser [:clouserw]]

this got onto prod long ago