Closed Bug 689277 Opened 8 years ago Closed 8 years ago

Memory leak on low resource situations for Windows software updates

Categories

(Toolkit :: Application Update, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: bbondy, Assigned: bbondy)

Details

Attachments

(1 file)

When doing the application update service I noticed a memory leak. 

This is a memory leak that will hardly ever be hit, but should be fixed in any case. 

> BOOL 
> WinLaunchChild(const PRUnichar *exePath, int argc, char **argv)
> {
>  PRUnichar** argvConverted = new PRUnichar*[argc];
>  if (!argvConverted)
>    return FALSE;

>  for (int i = 0; i < argc; ++i) {
>    argvConverted[i] = AllocConvertUTF8toUTF16(argv[i]);
>    if (!argvConverted[i]) {
>      // <--- Should free memory here
>      return FALSE;
>    }
>  }
Assignee: nobody → netzen
Summary: Memory leak on low resource situations → Memory leak on low resource situations for Windows software updates
Attachment #562525 - Flags: review?(robert.bugzilla)
OS: All → Windows 7
https://hg.mozilla.org/mozilla-central/rev/0da5a60d9893
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.