Flag require("chrome") for SDK add-ons

RESOLVED FIXED in 6.2.6

Status

addons.mozilla.org Graveyard
Add-on Validation
P2
normal
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: jorgev, Assigned: robhudson)

Tracking

unspecified
6.2.6
Dependency tree / graph

Details

(Whiteboard: [ReviewTeam])

(Reporter)

Description

6 years ago
The validator needs to show a warning if an SDK-based add-on is using the chrome module. This should make it easy to identify the SDK add-ons that are trivial to review from the ones that need some extra attention.

We need to look for the following code:
require("chrome")

And show a warning that says something like: "This SDK-based add-on uses interfaces that aren't part of the SDK."
kumar and mbasta can guide or help review on this
Assignee: nobody → chudson
Target Milestone: Q4 2011 → 6.2.6
Blocks: 691968
(Assignee)

Comment 2

6 years ago
Would this also need to look for the use of "Components" until bug 636145 lands?
(Reporter)

Comment 3

6 years ago
(In reply to Rob Hudson [:robhudson] from comment #2)
> Would this also need to look for the use of "Components" until bug 636145
> lands?

Good catch! Yes, we should flag it too.
(Assignee)

Comment 4

6 years ago
https://github.com/robhudson/amo-validator/commit/2694c0b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Blocks: 695233
(Reporter)

Comment 5

6 years ago
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.