689371 - Auto-determine locale and use profile locale

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Osmose [:osmose, :mkelly]]

Currently, the site does not set a user's locale when they register. The site should take the user's locale upon registration and store it in the user profile, and use this stored locale as the user's locale across the site.

Comment 1

[Fred Wenzel [:wenzel]]

How is that different from detecting the locale and stuffing it into the URL? Is there a reason to keep it around outside a request/response context?

Comment 2

[Osmose [:osmose, :mkelly]]

We allow users to change their locale so that they can access banners from different locales. It was a possibly incorrect assumption that this would affect the rest of the site's language as well.

chelsea: Do we want locale choice to only affect banners seen, or the entire site's locale?

Comment 3

[Chelsea Novak [:chelsea]]

Let's make banner language an option in the banner wizard for 1.1

Comment 4

[Osmose [:osmose, :mkelly]]

Fixed in https://github.com/mozilla/affiliates/commit/14534ab074b429e3a6e41df993d8e5f270a2dd59

User locales are now auto-detected when a user activates their account and have their browser locale set to a locale that Affiliates supports.

Comment 5

[Matt Brandt [:mbrandt]]

QA verified. Creating a new account with a locale such as de-DE results in a properly localized site. Banner images are correctly localized. After editing the user profile to Spanish, new banner creation properly results in banners localized to the new locale while the site remains in German.

Comment 6

[Matt Brandt [:mbrandt]]

Attachment: screenshot