689524 - [tabletui] about:home title is not displayed in the landscape tabs sidebar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Attachment: about:home title

Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1

Steps to reproduce:
1. Open Fennec App
2. Switch device to landscape
3. Go to about:home page

Expected result:
Under the page's thumbnail is displayed its title.

Actual result:
about:home title is missing from tab's panel.

Comment 1

[Martijn Wargers (dead)]

About:home doesn't show 'Firefox/Fennec start' in the url bar either. That's why there is no title in the page thumbnail.

Comment 2

[Aaron Train [:aaronmt]]

Really, this bug is about providing a title for about:home. Maybe something like "'Nightly/Aurora/Firefox' Start"?

Comment 3

[Aaron Train [:aaronmt]]

But then again, providing a title will hide the 'Enter search or Address' text which is more important for the user to see where they should begin typing an adress in the URL bar. I'm inclined that this will be a WONTFIX.

Comment 4

[Lucas Rocha (:lucasr)]

If designers really want this, we can special case about:home in the tabs pans and menu. Madhava, Ian, what do you think?

Comment 5

[Matt Brubeck (:mbrubeck)]

about:home does have a title ("<AppName> Start").   The title already appears in the portrait tab menu, as well as in bookmarks, and even sometimes in the landscape tablet sidebar on session restore.  It is intentionally suppressed from appearing in the url bar.  I think we should continue to suppress it in the url bar, but allow it to appear in the tab sidebar.

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: Show title on tabs showing about:home

Comment 7

[Matt Brubeck (:mbrubeck)]

Comment on attachment 562792 [details] [diff] [review]
Show title on tabs showing about:home

Hmm, this ends up hiding the caption for pages that have no title, like:
http://people.mozilla.com/~mbrubeck/test/form-background.html

I think we want to continue showing the URL as a fallback *except* when the URL is about:blank or about:empty, even though it means slightly more special-case code.

Comment 8

[Lucas Rocha (:lucasr)]

Landed with Matt's suggested changes:
http://hg.mozilla.org/integration/mozilla-inbound/rev/fd799dc86116

Comment 9

[Michael Wu [:mwu]]

https://hg.mozilla.org/mozilla-central/rev/fd799dc86116

Comment 10

[Carla Nadastean]

Retested bug with:
Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20111020
Firefox/10.0a1 Fennec/10.0a1
Device: Acer ICONIA A500
OS: Android 3.1

Bug no longer reproducible on Firefox 10. "Nightly Start" title is displayed under about:home page thumbnail.

NOTE: Bug is reproducible on Aurora, about:home title is missing under page thumbnail.
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a2)Gecko/20111020
Firefox/9.0a2 Fennec/9.0a2
Device: Acer ICONIA A500
OS: Android 3.1