689560 - Add progress indication to Reftest

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: Add log line: REFTEST INFO | Test Remaining: X

Here's a patch that adds a simple test remaining info line to reftest as a progress indicator. I've been using this locally and it's useful.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So, for what it's worth, there used to be a progress indicator in the titlebar, and then we started using windows without titlebars, which I thought was temporary...

It would be nice if we could squeeze this into the TEST-START line; ted would probably know if that's ok.

If not, at least put it right next to where we set document.title (and make it have the same info.

Comment 2

[(not currently active) Ted Mielczarek]

I don't think anything depends on parsing the TEST-START line, so squeezing it in there ought to be fine. And yeah, I added this a while ago, I didn't realize we lost the titlebar. :-/

Comment 3

[Benoit Girard (:BenWa)]

Attachment: Add progress to TEST-START line

Sample output:

REFTEST TEST-START | file:///Users/bgirard/mozilla/mozilla-central/tree/modules/libpr0n/test/reftest/pngsuite-palettes/ps1n0g08.png | 196 / 7036 (2%)
REFTEST TEST-START | file:///Users/bgirard/mozilla/mozilla-central/tree/modules/libpr0n/test/reftest/pngsuite-palettes/ps1n0g08.html | 196 / 7036 (2%)
REFTEST TEST-PASS | file:///Users/bgirard/mozilla/mozilla-central/tree/modules/libpr0n/test/reftest/pngsuite-palettes/ps1n0g08.png | image comparison (==)
REFTEST INFO | Loading a blank page
REFTEST TEST-START | file:///Users/bgirard/mozilla/mozilla-central/tree/modules/libpr0n/test/reftest/pngsuite-palettes/ps1n2c16.png | 197 / 7036 (2%)
REFTEST TEST-START | file:///Users/bgirard/mozilla/mozilla-central/tree/modules/libpr0n/test/reftest/pngsuite-palettes/ps1n2c16.html | 197 / 7036 (2%)
REFTEST TEST-PASS | file:///Users/bgirard/mozilla/mozilla-central/tree/modules/libpr0n/test/reftest/pngsuite-palettes/ps1n2c16.png | image comparison (==)
REFTEST INFO | Loading a blank page
REFTEST TEST-START | file:///Users/bgirard/mozilla/mozilla-central/tree/modules/libpr0n/test/reftest/pngsuite-palettes/ps2n0g08.png | 198 / 7036 (2%)
REFTEST TEST-START | file:///Users/bgirard/mozilla/mozilla-central/tree/modules/libpr0n/test/reftest/pngsuite-palettes/ps2n0g08.html | 198 / 7036 (2%)

Comment 4

[Benoit Girard (:BenWa)]

Ignore the first line removal, I did 'diff' instead of 'qdiff'

Comment 5

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f3b6a106ed8

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/3f3b6a106ed8