Last Comment Bug 689562 - [TABLET UI] Refresh button is not fully highlighted when it's tapped
: [TABLET UI] Refresh button is not fully highlighted when it's tapped
: verified-aurora
Product: Fennec Graveyard
Classification: Graveyard
Component: General (show other bugs)
: Trunk
: ARM Android
-- normal (vote)
: Firefox 9
Assigned To: Wesley Johnston (:wesj)
Depends on:
  Show dependency treegraph
Reported: 2011-09-27 07:14 PDT by Cristian Nicolae (:xti)
Modified: 2011-09-30 08:04 PDT (History)
12 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

screenshot (92.56 KB, image/png)
2011-09-27 07:14 PDT, Cristian Nicolae (:xti)
no flags Details
Patch (890 bytes, patch)
2011-09-27 10:06 PDT, Wesley Johnston (:wesj) review+
christian: approval‑mozilla‑aurora+
Details | Diff | Splinter Review

Description User image Cristian Nicolae (:xti) 2011-09-27 07:14:33 PDT
Created attachment 562760 [details]

Tapping on refresh button will not be fully highlighted as you can see on the attached screenshot. Bookmark button, favicon button, back&forward arrows or the URL Bar are completely highlighted when a tap is performed.

Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110927
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1
Comment 1 User image Aaron Train [:aaronmt] 2011-09-27 07:22:24 PDT
Same thing happens when you tap and hold on the site-identity button. They might simply just have different dimensions than the other glyphs on the navigation bar (i.e., star icon, menu button).
Comment 2 User image Wesley Johnston (:wesj) 2011-09-27 10:06:37 PDT
Created attachment 562799 [details] [diff] [review]

Whoops. Missed this in some last minute size fixes. This moves this padding to the buttons instead of the box. We still need some padding on the box so that we get an inset border.

Not sure about the favicon thing, but some of that was just backed out, so maybe that's why I can't see it right now?
Comment 4 User image Wesley Johnston (:wesj) 2011-09-28 12:40:08 PDT
If this looks good, I'll nominate it for Aurora.
Comment 5 User image Michael Wu [:mwu] 2011-09-29 01:31:02 PDT
Comment 6 User image christian 2011-09-29 14:50:08 PDT
We wouldn't track this but we'll approve the fix. Please land on releases/mozilla-aurora as soon as you can.
Comment 7 User image Matt Brubeck (:mbrubeck) 2011-09-29 16:01:29 PDT
Pushed to Aurora for Firefox 9:
Comment 8 User image Aaron Train [:aaronmt] 2011-09-30 08:04:16 PDT
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a2) Gecko/20110930 Firefox/9.0a2 Fennec/9.0a2

Note You need to log in before you can comment on or make changes to this bug.