Closed Bug 689562 Opened 8 years ago Closed 8 years ago

[TABLET UI] Refresh button is not fully highlighted when it's tapped

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set

Tracking

(firefox9- fixed)

VERIFIED FIXED
Firefox 9
Tracking Status
firefox9 - fixed

People

(Reporter: xti, Assigned: wesj)

Details

(Keywords: verified-aurora)

Attachments

(2 files)

Attached image screenshot
Tapping on refresh button will not be fully highlighted as you can see on the attached screenshot. Bookmark button, favicon button, back&forward arrows or the URL Bar are completely highlighted when a tap is performed.

--
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110927
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1
Group: core-security
Same thing happens when you tap and hold on the site-identity button. They might simply just have different dimensions than the other glyphs on the navigation bar (i.e., star icon, menu button).
Attached patch PatchSplinter Review
Whoops. Missed this in some last minute size fixes. This moves this padding to the buttons instead of the box. We still need some padding on the box so that we get an inset border.

Not sure about the favicon thing, but some of that was just backed out, so maybe that's why I can't see it right now?
Assignee: nobody → wjohnston
Attachment #562799 - Flags: review?(lucasr.at.mozilla)
Attachment #562799 - Flags: review?(lucasr.at.mozilla) → review+
If this looks good, I'll nominate it for Aurora.
https://hg.mozilla.org/mozilla-central/rev/482cba26ee79
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 10
We wouldn't track this but we'll approve the fix. Please land on releases/mozilla-aurora as soon as you can.
Attachment #562799 - Flags: approval-mozilla-aurora+
Pushed to Aurora for Firefox 9:
https://hg.mozilla.org/releases/mozilla-aurora/rev/14c7c295a445
Target Milestone: Firefox 10 → Firefox 9
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a2) Gecko/20110930 Firefox/9.0a2 Fennec/9.0a2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.