689562 - [TABLET UI] Refresh button is not fully highlighted when it's tapped

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Attachment: screenshot

Tapping on refresh button will not be fully highlighted as you can see on the attached screenshot. Bookmark button, favicon button, back&forward arrows or the URL Bar are completely highlighted when a tap is performed.

--
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110927
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1

Comment 1

[Aaron Train [:aaronmt]]

Same thing happens when you tap and hold on the site-identity button. They might simply just have different dimensions than the other glyphs on the navigation bar (i.e., star icon, menu button).

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Whoops. Missed this in some last minute size fixes. This moves this padding to the buttons instead of the box. We still need some padding on the box so that we get an inset border.

Not sure about the favicon thing, but some of that was just backed out, so maybe that's why I can't see it right now?

Comment 3

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/482cba26ee79

Comment 4

[Wesley Johnston (:wesj)]

If this looks good, I'll nominate it for Aurora.

Comment 5

[Michael Wu [:mwu]]

https://hg.mozilla.org/mozilla-central/rev/482cba26ee79

Comment 6

[LegNeato]

We wouldn't track this but we'll approve the fix. Please land on releases/mozilla-aurora as soon as you can.

Comment 7

[Matt Brubeck (:mbrubeck)]

Pushed to Aurora for Firefox 9:
https://hg.mozilla.org/releases/mozilla-aurora/rev/14c7c295a445

Comment 8

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:9.0a2) Gecko/20110930 Firefox/9.0a2 Fennec/9.0a2