689570 - Add a new phase to the build for FRR compilation

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Brent Baker]

We should remove the current FRR builder from the 'deep' phase of the build and add a parallel phase to deep to compile FRR builds.

This would allow for the quickest turn around on FRR builds since it would not be tied to the entire deep phase builds which are currently 6+ hours. This phases would have its own queue of builds and would build as often as it was able to _without_ ties to the deep phase. This _will_ introduce a possible scenario where during integration times a specific revision may have successfully passed through deep but not FRR or vice versa.

Comment 1

[James Sudduth]

Attachment: Move the FRR build/test out of deep.

One thing I'm not sure about in this patch is how best to indicate to BB that it should wait for *all* the Phase 1 tests to pass. In tamarinredux.py the frr scheduler repeats the builder dependencies for each test builder that needs to succeed using the same builder name. Will BB accept this? Is there a better syntax? Can we just wait for the windows-test builder to succeed? Should we wait for the long pole only (linux-mips)?

Comment 2

[James Sudduth]

Attachment: Adds a watcher config file for the FRR build.

I've already created the necessary pending and processed folders on playercore and also created a BuildBot Watcher FRR service to use this file.

Comment 3

[Brent Baker]

Comment on attachment 563200 [details] [diff] [review]
Move the FRR build/test out of deep.

Review of attachment 563200 [details] [diff] [review]:
-----------------------------------------------------------------

Add an email notifier to send pass/fail updates for the 

Remove frr-windows from the deep section in the waterfall header

::: build/buildbot/master/tamarinredux.py
@@ +109,5 @@
>                                    ["linux-arm-test", "linux-arm-smoke"],
>                                    ["linux-mips-test", "linux-mips-smoke"],
>                                   ])
>  
> +    frr = Scheduler(name="frr", branch=BRANCHES, treeStableTimer=30, fileIsImportant=startCompile,

This should mimic the 'deep' scheduler (PhaseTwoScheduler)

@@ +113,5 @@
> +    frr = Scheduler(name="frr", branch=BRANCHES, treeStableTimer=30, fileIsImportant=startCompile,
> +                    changeDir="changes/frr/processed", properties={'silent':'false'},
> +                    builderNames=["windows-frr"],
> +                    builderDependencies=[
> +                                  ["windows-frr", "windows-test"],

Only dependent on windows-test

Comment 4

[Brent Baker]

Comment on attachment 563201 [details] [diff] [review]
Adds a watcher config file for the FRR build.

Review of attachment 563201 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildbot/scripts/master/watcher_config_redux_frr.py
@@ +48,5 @@
> +LOGQUEUETIMES = False
> +
> +# List of buildsets that watcher will wait for before starting a build
> +WATCHED_BUILDSETS = ['frr']
> +PRIORITY_1_BRANCH = 'tamarin-redux'

match the deep watcher script, this should be tamarin-redux-frr so that builds can be triggered for the specific branch

Comment 5

[James Sudduth]

Attachment: Move the FRR build/test out of deep.

Comment 6

[James Sudduth]

Attachment: Adds a watcher config file for the FRR build.

Comment 7

[Brent Baker]

Comment on attachment 563744 [details] [diff] [review]
Move the FRR build/test out of deep.

Review of attachment 563744 [details] [diff] [review]:
-----------------------------------------------------------------

Seems like it should work to me based on looking at the code.

Comment 8

[Brent Baker]

Comment on attachment 563745 [details] [diff] [review]
Adds a watcher config file for the FRR build.

This file should have a copyright of 2011

Comment 9

[James Sudduth]

Attachment: Updating the copyright date to 2011

Comment 10

[Tamarin Bot]

changeset: 6611:88cb5d52069f
user:      James Sudduth <[e-mail]>
summary:   Bug 689570 - Add a new phase to the build for FRR compilation (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/88cb5d52069f

Comment 11

[Dan Smith]

This can be closed, yes?