update CI build code to work with BB or Jenkins

NEW
Assigned to

Status

Tamarin
Build Config
P3
normal
7 years ago
6 years ago

People

(Reporter: Trevor Baker, Assigned: Trevor Baker)

Tracking

(Depends on: 2 bugs)

unspecified
Q1 12 - Brannan
x86_64
Windows 7
Dependency tree / graph
Bug Flags:
flashplayer-qrb +

Details

Attachments

(3 attachments, 5 obsolete attachments)

(Assignee)

Description

7 years ago
A few problems when using compile-generic.sh from within Jenkins 

1. the script creates a builds dir outside of the repo, which is causing problems because is outside of the "workspace" in Jenkins 
2. I don't want to copy the builds to asteam by default. If I want to archive artifacts I can do it via an artifact publisher
3. nor do I want to delete the objdir
(Assignee)

Updated

7 years ago
Blocks: 689592
(Assignee)

Updated

7 years ago
Summary: add mechanism to skip uploading shells to asteam and not delete objdir → compile-generic.sh problems when used within Jenkins
(Assignee)

Comment 1

7 years ago
Created attachment 562793 [details] [diff] [review]
condition code using JENKINS_HOME env variable
Attachment #562793 - Flags: review?(dschaffe)
(Assignee)

Comment 2

7 years ago
Created attachment 562798 [details] [diff] [review]
condition code using JENKINS_HOME env variable
Attachment #562793 - Attachment is obsolete: true
Attachment #562793 - Flags: review?(dschaffe)
(Assignee)

Comment 3

7 years ago
Created attachment 562800 [details] [diff] [review]
condition code using JENKINS_HOME env variable
Attachment #562798 - Attachment is obsolete: true
(Assignee)

Comment 4

7 years ago
Created attachment 562813 [details] [diff] [review]
condition code using JENKINS_HOME env variable

this passed in the sandbox
Attachment #562800 - Attachment is obsolete: true
Attachment #562813 - Flags: review?(dschaffe)

Updated

7 years ago
Attachment #562813 - Flags: review?(dschaffe) → review+
(Assignee)

Comment 5

7 years ago
Created attachment 563477 [details] [diff] [review]
patch to get compile and test working on mac and windows in jenkins
Attachment #562813 - Attachment is obsolete: true
Attachment #563477 - Flags: review?(dschaffe)

Comment 6

7 years ago
Comment on attachment 563477 [details] [diff] [review]
patch to get compile and test working on mac and windows in jenkins

in compile-generic.sh did you mean to remove the last line rm -fr objdir  

I'm not convinced pre-pending the existing INCLUDE, LIB, LIBPATH values is good since it may create confusing situations.   Like we should either require the values to be set correctly on the machine and we assume they are already set or require the script to set the values.  Combining the two is confusing.
Attachment #563477 - Flags: review?(dschaffe) → review+
(Assignee)

Updated

7 years ago
Summary: compile-generic.sh problems when used within Jenkins → update CI build code to work with BB or Jenkins
(Assignee)

Comment 7

7 years ago
Created attachment 563514 [details] [diff] [review]
patch to return integer rev id as environment variable

patch applies to:
https://github.com/jenkinsci/mercurial-plugin

commit 385b155c2366cc22f479b5288183bf853022dcee
Author: Jesse Glick <jesse.glick@oracle.com>
Date:   Fri Sep 9 16:09:38 2011 -0400
(Assignee)

Comment 8

7 years ago
(In reply to Dan Schaffer from comment #6)
> in compile-generic.sh did you mean to remove the last line rm -fr objdir  

Yes, I am archiving the artifact from there are reusing it in downstream jobs. This is to work around the BB system putting the shells in a /builds/ dir outside the repo.  In Jenkins, I can't get outside of WORKSPACE, so addressing the shell from objdir is the intent.


> I'm not convinced pre-pending the existing INCLUDE, LIB, LIBPATH values is
> good since it may create confusing situations.   Like we should either
> require the values to be set correctly on the machine and we assume they are
> already set or require the script to set the values.  Combining the two is
> confusing.

At the heart of it is that jenkins is really flexible in letting you add and and remove nodes at will to scale up or down.  Most/all of our buildbot config is in hg, while it won't be practical to use the same mechanisms for Jenkins.  My thoughts on best practices for Jenkins are still formulating, but artificially constraining ourselves with such a flexible tool seems like the wrong approach.
(Assignee)

Updated

7 years ago
Attachment #563514 - Flags: review?(dschaffe)

Updated

7 years ago
Attachment #563514 - Flags: review?(dschaffe) → review+
(Assignee)

Updated

7 years ago
Assignee: nobody → trbaker
Flags: flashplayer-qrb+
Target Milestone: --- → Q1 12 - Brannan

Updated

7 years ago
Priority: -- → P3

Comment 9

7 years ago
Created attachment 566303 [details]
patch to performance runtests fix, add socket timeout
Attachment #566303 - Flags: review?(trbaker)
(Assignee)

Updated

7 years ago
Depends on: 525089
(Assignee)

Updated

7 years ago
Depends on: 695906
(Assignee)

Updated

7 years ago
Attachment #566303 - Flags: review?(trbaker) → review+
(Assignee)

Comment 10

7 years ago
Created attachment 571009 [details] [diff] [review]
patch from HM repo

consolidated patch to bring TR up to date with HM build changes
Attachment #563477 - Attachment is obsolete: true
Attachment #571009 - Flags: review?(brbaker)

Comment 11

7 years ago
changeset: 6832:7cc3acef01d7
user:      Brent Baker <brbaker@adobe.com>
summary:   Update to latest jenkins tweaks based on bz:689595

http://hg.mozilla.org/tamarin-redux/rev/7cc3acef01d7

Comment 12

6 years ago
Comment on attachment 571009 [details] [diff] [review]
patch from HM repo

removing review. Not sure how much of this is still to land. Most of it has already landed in tamarin-redux via the float merge
Attachment #571009 - Flags: review?(brbaker)
You need to log in before you can comment on or make changes to this bug.