68960 - countrywide.com - [LAYER]JavaScript Pop-ups don't work appear

Status: RESOLVED WORKSFORME

(Tech Evangelism Graveyard :: English US, defect, P3)

Description

[edburns]

This occurrs on both the Netscape_20000922_BRANCH and on the trunk.


Steps to reproduce:

1. Visit http://www.countrywide.com/

2. After the page loads, move the mouse over the "we are a direct lender"
text.

Expected results: a "pop-up" like thingy appears displaying the text "no
middlement means less read tape...".

Actual results: nothing happens

Reproducible: always.

Comment 1

[Tim Powell]

This appears to be a problem with browser detection code. It is looking for 
document.all and document.layers which will fail with Mozilla.

Comment 2

[Phil Schwartau]

That's right - Layers and document.all with no code path for DOM-compliant 
browsers. For example, here is the browser-sniffing being used at the site: 

                
          NS4 = (document.layers) ? 1 : 0;
          IE4 = (document.all) ? 1 : 0;
          ver4 = (NS4 || IE4) ? 1 : 0;


And then they have functions like this: 


// Function to 'activate' images.
function imgOn(imgName) {
  if (!ver4) return;

  if (NS4) {
    document.MainBodyDiv.document[imgName].src = eval(imgName + "_on.src");
  }
  else {
    document[imgName].src = eval(imgName + "_on.src");
  }
}



In Mozilla or NN6, the site's flags NS4, IE4, ver4 evaluate to false
(NN4.x supported layers, but Mozilla/NN6 does not). Therefore functions
like imgOn() don't run as expected in Mozilla/NN6. 


For more information on this issue, see bug 50711. Reassigning to 
Evangelism component - 

Comment 3

[/\/\arcio Galli]

Agreed evangelism issue.

comments:
--------
* not affects the user access experience. I mean have access to pages.

* expand collapse menu does not work on secundary pages (but not affects user
access experience too because the submenus are already open using Mozilla).

Recommends to use the Ultimate Client Sniffer:
http://www.mozilla.org/docs/web-developer/sniffer/browser_type.html
to sniff the client


And if(is_gecko) { 	// see above URL.

then do the proper DOM operations with the elements in the page.

For example.. functions like this:
------
 function popUpHide(whichDiv) {
			if (!ver4) return;
			if (pageLoaded != 0) {
				if (NS4) {
				    eval ("document." + whichDiv + ".visibility = 'hidden'");
				}
				else {
				    eval (whichDiv + ".style.visibility = 'hidden'");
				}
			}
				
		}

proposed should be more like:

 function popUpHide(whichDiv) {
			if (!ver4) return;
			if (pageLoaded != 0) {

				if (is_gecko) {
					document.getElementById(whichDiv).style.visibility='hidden';
				}
				if (NS4) {
				    eval ("document." + whichDiv + ".visibility = 'hidden'");
				}
				else {
				    eval (whichDiv + ".style.visibility = 'hidden'");
				}
			}
				
		}

Comment 4

[Blake Ross]

Reassigning evangelism bugs to [e-mail].

Comment 5

[Bob Clary [:bc] (inactive)]

All Evangelism Bugs are now in the Product Tech Evangelism. See bug 86997 for
details.

Comment 6

[Doron Rosenberg (IBM)]

the pop-up in question is gone, though the img hover effects still does not work
(the dhtml menus when you click the images works though).

Comment 7

[Doron Rosenberg (IBM)]

also need to upgrade hiermenu from 4.0.x to 4.1.x

Comment 8

[Zach Lipton [:zach]]

Mass reassign of all tech-evangelism us general bugs assigned to bc to 
doron except bc's P1 bugs. You may search for this mass reassign (it is 
305 bugs) by searching for the keyword 'greeneggsandham'

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Site redesign. The new version supports W3C DOM. Marking as WorksForMe