Closed
Bug 689792
Opened 13 years ago
Closed 13 years ago
move services APIs into jetpack worker
Categories
(Mozilla Labs :: OpenWebApps, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mixedpuppy, Unassigned)
Details
Attachments
(1 file)
We don't want mediator and service APIs to be injected into all content, they should only be injected where necessary. This also removes the need for contentWindow use.
|
Reporter | |
Comment 1•13 years ago
|
||
This also removes the invokeService call in services.js. There is some demo related code in ui.js and api.js that calls this, those will be broken, but are unimportant and can either be fixed later, or simply, preferably, removed.
|
|
Reporter | |
Comment 2•13 years ago
|
||
Attachment #563154 -
Flags: review?(anant)
|
|
Reporter | |
Comment 3•13 years ago
|
||
review for openwebapps part of change submitted, f1 pull request will be soon
|
||
Comment 4•13 years ago
|
||
Comment on attachment 563154 [details]
Pointer to pull request
Looks good!
Attachment #563154 -
Flags: review?(anant) → review+
|
|
Reporter | |
Comment 5•13 years ago
|
||
openwebapps part pushed https://github.com/mozilla/openwebapps/commit/9fcdc636e32e45962379f0de6d6cca59d0d5bebf
|
|
Reporter | |
Comment 6•13 years ago
|
||
|
|
Reporter | |
Comment 7•13 years ago
|
||
This has been done
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•