689799 - Localize category and badge previews / auto-generate?

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: affiliates.mozilla.org, defect)

Description

[Osmose [:osmose, :mkelly]]

Subcategories and banner previews are not currently set to show a localized preview. This is separate from the final generated badge on step 3, which WILL be localized.

The previews for these should be able to be localized, or perhaps even auto-generated.

Comment 1

[Chris More [:cmore]]

Would require a preview images table that references a specific category/subcategory.

Comment 2

[Osmose [:osmose, :mkelly]]

How about we only add previews for each banner, and subcategories will choose a random one and use it?

Comment 3

[Chris More [:cmore]]

mkelly: not a bad idea! I like it.

Comment 4

[Chris More [:cmore]]

Attachment: Default banner preview

Edge case and will more likely never display.

Comment 5

[Osmose [:osmose, :mkelly]]

Can you remove the Firefox text? It clashes with the text below the badge.

Comment 6

[Chris More [:cmore]]

Attachment: Default preview without Firefox text

Comment 7

[Osmose [:osmose, :mkelly]]

Moving to next release, the code review on this feature isn't complete.

Comment 8

[[github robot]]

Commit pushed to https://github.com/mozilla/affiliates

https://github.com/mozilla/affiliates/commit/58c43b72a838542c9235d83637aadc9fad27b4ef
Add tests and update fixtures.

fix bug 689799

Comment 9

[Matt Brandt [:mbrandt]]

QA verified on stage. Changing locals in the users profile successfully changes the language the banners are localized in. If a banner is not localized a default Firefox images is displayed.