689811 - Packager adds an unrecognized element to the install.rdf

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[krupa raj[:krupa]]

Attachment: add-on created via packager

steps to reproduce:
1. create an add-on at https://addons-dev.allizom.org/en-US/developers/addon/package/
2. Upload that add-on at https://addons-dev.allizom.org/en-US/developers/addon/submit/2

actual behavior:
Uploaded add-on has a warning about 'Unrecognized element in install.rdf'
See  https://addons-dev.allizom.org/en-US/developers/upload/8620ce11ce994b1dac61731c43ec8472

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

should be <em:creator> for a single entry, or <em:developer> for multiple.
https://developer.mozilla.org/en/install_manifests#creator

Comment 2

[Christopher Van Wiemeersch [:cvan]]

The issue was <em:author> was used (where it should've been <em:creator>). So, currently we allow <em:creator> for a single entry and <em:contributor> for (multiple) contributors. Does this sound good? Or, do we want support for <em:developer> as well?

https://github.com/cvan/addon-packager/commit/87742cd5

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

I think creator and contributors should cover most cases, so there's no need to make it more complicated.

Comment 4

[krupa raj[:krupa]]

verified at https://addons-dev.allizom.org/en-US/developers/upload/5976b71890b04e318b8c87863979781f

with pre-built features: https://addons-dev.allizom.org/en-US/developers/upload/12ba9010bfd3465d9b61a2eeddbf3fd5