Use MP tasks when possible for interrupts on Mac

RESOLVED WONTFIX

Status

NSPR
NSPR
P3
normal
RESOLVED WONTFIX
17 years ago
15 years ago

People

(Reporter: Simon Fraser, Assigned: Wan-Teh Chang)

Tracking

4.0.2
PowerPC
Mac System 8.5

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
The Mac implementation of interrupts currently uses a Time Manager task to do 
work every 8ms. Since the PrimeTime call is a 68k call, this incurs more overhead 
than we'd like.

An alternative is to use the MultiProcessor APIs when available (even on single 
CPU machines), since these will have a lower overhead.
(Reporter)

Comment 1

17 years ago
Created attachment 25408 [details] [diff] [review]
Initial cut at MP task implementation
(Reporter)

Comment 2

17 years ago
I've attached a first cut at an MP-task implementation of interrupts for Mac. I 
make no guarantees that this is safe, and won't crash, but it seems to work for 
me, and could be used as a basis for a real implementation.

Comment 3

17 years ago
how about the defered task manager?  does that have 68k overhead?  It exists even 
where the mp api's dont.

Comment 4

17 years ago
IIRC the deferred task manager is for tasks you want to perform as you leave an 
interrupt rather than an interrupt mechanism itself

Comment 5

17 years ago
I tried this patch and kept landing in macsbug (dsFSErr) and had to reboot my 
Mac.  I'm running OS 9.1.  I did try running other TCP/IP apps before mozilla but 
I still couldn't get past the profile picker dismissal.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → 4.2
Version: 3.0 → 4.0.2
(Assignee)

Comment 6

16 years ago
Simon,

Are we still going to use MP tasks?  I haven't seen any
activity on this bug.  Should I mark it "Future" or
WONTFIX?
(Reporter)

Comment 7

16 years ago
We need to do some performance evalutation on this. I'd keep it on the radar for 
now. It may be a good thing to do on Mac OS X, but not so good on 9.

Comment 8

16 years ago
I don't remember if I tested this on X but I do recall it didn't work at all for 
me under 9

Comment 9

15 years ago
Since we're now only supporting Mac OS X (where we don't need the MP tasks), I
think this can be closed.
(Assignee)

Comment 10

15 years ago
Marked the bug WONTFIX.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.