Closed
Bug 689917
Opened 13 years ago
Closed 13 years ago
Make the buildtool work with Git
Categories
(Cloud Services :: Server: Other, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tarek, Assigned: tarek)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
2.96 KB,
patch
|
rmiller
:
review+
|
Details | Diff | Splinter Review |
It'll be based on auto-detection for the main repo and for the deps
Assignee | ||
Comment 1•13 years ago
|
||
Seems to work fine, but please double-check that I've used the proper Git calls
Attachment #563070 -
Flags: review?(rmiller)
Comment 2•13 years ago
|
||
Comment on attachment 563070 [details] [diff] [review] Git support Review of attachment 563070 [details] [diff] [review]: ----------------------------------------------------------------- ::: mopytools/util.py @@ -185,3 +199,4 @@ > > force=False): > > if force and channel != 'dev': > > - cmd = 'hg up -C' > > + if is_git(): > > + cmd = 'git clean' `git clean` isn't what you want here... I think `git checkout --force` is what you want, which will overwrite any local changes in the working tree. @@ -190,2 +211,3 @@ > > else: > > - cmd = 'hg up' > > + if is_git(): > > + cmd = 'git checkout --force' And here `git checkout --force` will overwrite local changes, is that really what we want in this case?
Attachment #563070 -
Flags: review?(rmiller) → review-
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #563070 -
Attachment is obsolete: true
Attachment #563689 -
Flags: review?(rmiller)
Comment 4•13 years ago
|
||
Comment on attachment 563689 [details] [diff] [review] Git support v2 Review of attachment 563689 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #563689 -
Flags: review?(rmiller) → review+
Assignee | ||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/services/server-devtools/rev/cbf50f29865a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Whiteboard: [qa-
Updated•13 years ago
|
Whiteboard: [qa- → [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•