689924 - Change "Inspect" shortcut to Cmd+Opt+I, Web Console to Cmd+Opt+K (Mac Only)

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Anthony Ricaud (:rik)]

Safari, Chrome and Opera uses Cmd+Opt+I to launch their devtools. I think we should match that.

Might be worth changing other shortcuts to replace Shift by Opt also.

Comment 1

[Paul Rouget [:paul]]

> Might be worth changing other shortcuts to replace Shift by Opt also.

Which ones?

Comment 3

[Anthony Ricaud (:rik)]

I'm gonna reopen this one because it's only about Mac shortcuts.

The other bug says it can't be done because of Windows bindings.

(In reply to Paul Rouget [:paul] from comment #1)
> > Might be worth changing other shortcuts to replace Shift by Opt also.
> 
> Which ones?
Web Console and Error Console currently use Shift.

Comment 4

[Anthony Ricaud (:rik)]

Attachment: Patch

This changes the Web Console and Inspect tool to use Cmd+Alt shortcuts.

I left out the Error console cause I think it's not gonna be a tool for web developers.

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 574111 [details] [diff] [review]
Patch

>+#ifdef XP_MACOSX
>+    <key id="key_webConsole" key="&webConsoleCmd.commandkey;" oncommand="HUDConsoleUI.toggleHUD();" modifiers="accel,alt"/>
>+#else
>     <key id="key_webConsole" key="&webConsoleCmd.commandkey;" oncommand="HUDConsoleUI.toggleHUD();" modifiers="accel,shift"/>
>+#endif

     <key id="key_webConsole" key="&webConsoleCmd.commandkey;"
#ifdef XP_MACOSX
          modifiers="accel,alt"
#else
          modifiers="accel,shift"
#endif
          oncommand="HUDConsoleUI.toggleHUD();"/>

Comment 6

[Anthony Ricaud (:rik)]

Attachment: Patch v2

Thanks for the comment Dao, fixed.

I've put Dave for the review but I have no idea who I should ask to review.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Anthony Ricaud (:rik) from comment #6)
> Created attachment 574200 [details] [diff] [review] [diff] [details] [review]
> Patch v2
> 
> Thanks for the comment Dao, fixed.
> 
> I've put Dave for the review but I have no idea who I should ask to review.

You could ask any of the fine gentlemen listed in this page:

https://wiki.mozilla.org/Modules/Firefox

Comment 8

[Anthony Ricaud (:rik)]

Comment on attachment 574200 [details] [diff] [review]
Patch v2

Thanks Panos. Then I guess I should ask Dao.

Comment 9

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/192f8762963f

Comment 10

[Rob Campbell [:rc] (:robcee)]

Updating the summary to reflect reality.

This may severely impact people's muscle memory.

Comment 11

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/192f8762963f

Comment 12

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 574200 [details] [diff] [review]
Patch v2

Since this changes the key for a new feature, we should land this in aurora to get people used to it.

The webconsole key-binding should be considered a companion setting.

Low-risk. No code changes.

Comment 13

[LegNeato]

[triage comment]
Is there any downside to supporting both the current and this shortcut for web console? Hasn't web console shipped with that shortcut in multiple releases, and wouldn't we be breaking muscle memory that way?

Comment 14

[Rob Campbell [:rc] (:robcee)]

(In reply to Christian Legnitto [:LegNeato] from comment #13)
> [triage comment]
> Is there any downside to supporting both the current and this shortcut for
> web console? Hasn't web console shipped with that shortcut in multiple
> releases, and wouldn't we be breaking muscle memory that way?

like, having two shortcuts assigned for the web console? Only downside is some untested xul.

It does break muscle memory, and in some cases, interferes with other shortcuts requiring users to reconfigure hotkeys outside of Firefox (in my case, OmniFocus).

Comment 15

[Axel Hecht [:Pike]]

Did you test that this doesn't break existing localized shortcuts in localizations? (I don't think we have anything better than tweaking a mozmill l10n test and run through all localized builds.)

Comment 16

[Rob Campbell [:rc] (:robcee)]

uh, no, I have no idea how to test that.

I filed a follow-up bug to this: bug 706204 to restore the original web console shortcut as per legneato's comment 13. I'd like to get that into aurora at the same time.

Comment 17

[Anthony Ricaud (:rik)]

I just received an email asking me to land this on Aurora. Since I cannot do that, de-assigning myself.

Can someone take it?

Comment 18

[Paul Rouget [:paul]]

I will land that tomorrow.

Comment 19

[Paul Rouget [:paul]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fadc2aa37e9f

Comment 20

[Vlad [QA]]

I have tried this on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0) Gecko/20100101 Firefox/10.0 beta 2
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20100101 Firefox/10.0 beta 2

Cmd+Opt+I opens "Inspect" and Cmd+Opt+K opens "Web Console"

Setting resolution to Verified Fixed