Closed Bug 690080 Opened 9 years ago Closed 9 years ago

Tab focus ring enlarges tab

Categories

(Thunderbird :: Theme, defect)

9 Branch
All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 10.0

People

(Reporter: micmon, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

Starting with Thunderbird 5 I think, focus rings are shown on tabs labels. As soon as the ring is drawn, the tab grows by 1-2 pixels (vertically). This should be fixed or the focus ring be removed (Firefox does not shoe focus rings on tabs)
I agree that we should just remove the focus ring in this case…

Andreas, Paenglab, did either of you want to take this?

Thanks,
Blake.
Note that on Windows and Linux, the focus ring appears when tabbing to the, well, tab. Not sure about Mac.
Attached patch Remove the focus ring (obsolete) — Splinter Review
Simply remove the definitions.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #563428 - Flags: review?(bwinton)
This patch fixes the enlargement on focus with fixing the selector.

I added both patches so you can decide if you want to remove the focus ring or fix the problem. :-)
Attachment #563430 - Flags: review?(bwinton)
(In reply to Jim Porter (:squib) from comment #2)
> Note that on Windows and Linux, the focus ring appears when tabbing to the,
> well, tab. Not sure about Mac.

Of course, I meant on Firefox here. :)

Fixing the issue (i.e. not removing the focus-ring) is probably the best way, since we shouldn't regress accessibility if at all possible.
Comment on attachment 563428 [details] [diff] [review]
Remove the focus ring

Uh, yeah, I'm not entirely sure what I was thinking of when I said "remove it"...
Attachment #563428 - Flags: review?(bwinton) → review-
Comment on attachment 563430 [details] [diff] [review]
Fix the focus ring enlargement

Review of attachment 563430 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  r=me, and ui-r=me while I'm here.
Attachment #563430 - Flags: ui-review+
Attachment #563430 - Flags: review?(bwinton)
Attachment #563430 - Flags: review+
Keywords: checkin-needed
Attachment #563428 - Attachment is obsolete: true
Checked in: http://hg.mozilla.org/comm-central/rev/7265f78b6ceb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in before you can comment on or make changes to this bug.