690080 - Tab focus ring enlarges tab

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Michael Monreal [:micmon]]

Starting with Thunderbird 5 I think, focus rings are shown on tabs labels. As soon as the ring is drawn, the tab grows by 1-2 pixels (vertically). This should be fixed or the focus ring be removed (Firefox does not shoe focus rings on tabs)

Comment 1

[Blake Winton (:bwinton) (:☕️)]

I agree that we should just remove the focus ring in this case…

Andreas, Paenglab, did either of you want to take this?

Thanks,
Blake.

Comment 2

[Jim Porter (:squib)]

Note that on Windows and Linux, the focus ring appears when tabbing to the, well, tab. Not sure about Mac.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Remove the focus ring

Simply remove the definitions.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Fix the focus ring enlargement

This patch fixes the enlargement on focus with fixing the selector.

I added both patches so you can decide if you want to remove the focus ring or fix the problem. :-)

Comment 5

[Jim Porter (:squib)]

(In reply to Jim Porter (:squib) from comment #2)
> Note that on Windows and Linux, the focus ring appears when tabbing to the,
> well, tab. Not sure about Mac.

Of course, I meant on Firefox here. :)

Fixing the issue (i.e. not removing the focus-ring) is probably the best way, since we shouldn't regress accessibility if at all possible.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 563428 [details] [diff] [review]
Remove the focus ring

Uh, yeah, I'm not entirely sure what I was thinking of when I said "remove it"...

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 563430 [details] [diff] [review]
Fix the focus ring enlargement

Review of attachment 563430 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.  r=me, and ui-r=me while I'm here.

Comment 8

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/7265f78b6ceb