690163 - URL section "Attaching content scripts to tabs" incorrect?

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P2)

Description

[Terry R.]

Reported from the webmaster email address:

At the example "Attaching content scripts to tabs", the Widget ID is missing and it doesn't work.
The right way would be:

var widgets = require("widget");
var tabs = require("tabs");
 
var widget = widgets.Widget({
  id: "Div-Show",
  label: "Show divs",
  contentURL: "http://www.mozilla.org/favicon.ico",
  onClick: function() {
    tabs.activeTab.attach({
      contentScript:
        'var divs = document.getElementsByTagName("div");' +
        'for (var i = 0; i < divs.length; ++i) {' +
          'divs[i].setAttribute("style", "border: solid red 1px;");' +
        '}'
    });
  }
});

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Add an id to the widget.

So this patch adds an ID attribute to the widget's constructor.

I'm open to a better ID, though. :)

Comment 2

[Will Bamberg [:wbamberg]]

Comment on attachment 563254 [details] [diff] [review]
Add an id to the widget.

"Div-Show" would be a better ID, I think.

Thanks Terry R. for catching this, and KWierso for the patch! But this patch adds an attribute called "div" not one called "id" :(.

Comment 3

[Terry R.]

I wasn't the one who caught it.  Just passed on what someone reported.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Actually add an id to the widget constructor

Wow, can't believe I did that...

Comment 5

[Will Bamberg [:wbamberg]]

Comment on attachment 563267 [details] [diff] [review]
Actually add an id to the widget constructor

Thanks KWierso!

Comment 6

[Myk Melez [:myk] [@mykmelez]]

https://github.com/mozilla/addon-sdk/commit/13228be19730cb7b57e3ee52edeeba47661cca2d
https://github.com/mozilla/addon-sdk/commit/4f2ec8936c4bab1ed23b4688ae829d0968f7b0c6