690206 - Add output when compiler exits with non-zero exitcode; add compiler output to verbose

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Tools, enhancement, P4)

Description

[Chris Peyer]

Attachment: add error and verbose output

Add compiler output to verbose mode.

When compiler exits with non-zero exitcode, display an error message.  Note that only a message is displayed, the test is not failed.

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Comment on attachment 563276 [details] [diff] [review]
add error and verbose output

(Call me crazy, but it seems like this patch includes a lot of stuff that is not relevant to this ticket.)

Comment 2

[Brent Baker]

Comment on attachment 563276 [details] [diff] [review]
add error and verbose output

Review of attachment 563276 [details] [diff] [review]:
-----------------------------------------------------------------

please clean up the patch

Comment 3

[Chris Peyer]

Attachment: Correct patch

Forgot a . when creating patch.  Correct patch now pushed.

Comment 4

[Brent Baker]

Comment on attachment 563437 [details] [diff] [review]
Correct patch

Review of attachment 563437 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think this is doing what you want. I tweaked a file that I was forcing to be recompiled and the exitcode from the compilation was still 0 even though it did not compile. I duplicated the COMPILER EXITCODE logging outside of the if block, and you can see that it is returning 0 even though it fails to compile.

./runtests.py -f as3/AbcDecoder/simple.as
Tamarin tests started: 2011-09-29 13:33:31.278748
current configuration: x64-mac-tvm-release
avm version: 6579:41f0b26644a0
asc version: 5
thread count: 24
Executing 1 tests against vm: /Users/brbaker/hg/tamarin-redux/objdir/shell/avmshell
ERROR! COMPILER EXITCODE=0

[Compiler] Error #1084: Syntax error: expecting identifier before semicolon.
   as3/AbcDecoder/simple.as, Ln 46, Col 4: 
   var;
   ...^

1 error found
   FAILED! file did not compile: as3/AbcDecoder/simple.abc

FAILURES:
  as3/AbcDecoder/simple.abc : FAILED! file did not compile: as3/AbcDecoder/simple.abc
END FAILURES

::: test/util/runtestBase.py
@@ +1066,5 @@
>          try:
>              (f,err,exitcode) = self.run_pipe('%s %s' % (cmd,as_file),
>                                               outputCalls=outputCalls)
> +            if exitcode != 0:
> +                outputCalls.append((self.js_print, ('ERROR! COMPILER EXITCODE='+exitcode,)))

Can't combine string and ints here, need to do:

'ERROR! COMPILER EXITCODE=%s'%exitcode

Comment 5

[Brent Baker]

(In reply to Brent Baker from comment #4)
> ::: test/util/runtestBase.py
> @@ +1066,5 @@
> >          try:
> >              (f,err,exitcode) = self.run_pipe('%s %s' % (cmd,as_file),
> >                                               outputCalls=outputCalls)
> > +            if exitcode != 0:
> > +                outputCalls.append((self.js_print, ('ERROR! COMPILER EXITCODE='+exitcode,)))
> 
> Can't combine string and ints here, need to do:
> 
> 'ERROR! COMPILER EXITCODE=%s'%exitcode

Actually I guess it should be:

outputCalls.append((self.js_print, ('ERROR! COMPILER EXITCODE=%i'%exitcode,)))

Comment 6

[Chris Peyer]

Attachment: fix str + int issue

Comment 7

[Brent Baker]

Comment on attachment 563457 [details] [diff] [review]
fix str + int issue

Review of attachment 563457 [details] [diff] [review]:
-----------------------------------------------------------------

Still marking as r- since asc is returning a 0 exitcode even when it fails to compile, so this is NOT doing what you expect

Comment 8

[Chris Peyer]

Attachment: check for non-zero exitcode - add comment explaining code

Unfortunately asc has a zero exitcode even when there are errors, so the exitcode checking only applies to falcon.

Verbose code still works for both compilers.

Comment 9

[Chris Peyer]

Attachment: instead of printing warning, fail the test

Improvement on previous patch.  Treat non-zero exitcode as a failure, add support to set it as an expected failure.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.