Last Comment Bug 690207 - Skip IMAP folders on import from Outlook
: Skip IMAP folders on import from Outlook
Status: RESOLVED FIXED
: perf
Product: MailNews Core
Classification: Components
Component: Import (show other bugs)
: unspecified
: All Windows 7
: -- normal (vote)
: Thunderbird 11.0
Assigned To: Mike Kaganski
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-28 19:38 PDT by Mike Kaganski
Modified: 2011-11-23 02:39 PST (History)
4 users (show)
vseerror: in‑litmus?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Skip IMAP folders on import from Outlook (842 bytes, patch)
2011-09-28 19:44 PDT, Mike Kaganski
mozilla: review+
Details | Diff | Splinter Review
Alternative patch (4.86 KB, patch)
2011-09-30 04:21 PDT, Mike Kaganski
mozilla: review-
Details | Diff | Splinter Review

Description Mike Kaganski 2011-09-28 19:38:52 PDT
When importing mail from MS Outlook, we should skip folders that represent IMAP accounts, as their contents will be accessible in TB.
Comment 1 Mike Kaganski 2011-09-28 19:44:33 PDT
Created attachment 563277 [details] [diff] [review]
Skip IMAP folders on import from Outlook

David, please test how it works. Unfortunately, I cannot test it at the moment.
Comment 2 Mike Kaganski 2011-09-28 20:24:56 PDT
See also Bug 592022 - there a user suffered from being unable to import an IMAP folder from OE.
Probably, there should be some way for user to decide if he wants to import IMAP mails or not...
Comment 3 Mike Kaganski 2011-09-30 04:21:20 PDT
Created attachment 563710 [details] [diff] [review]
Alternative patch

This patch does the same as attachment 563277 [details] [diff] [review], with the following differences:
1. It creates empty folders for each folder in the origial IMAP account (previous one creates only the root folder for the account);
2. It reports the skipped IMAP folders in the Import Results window.

The test describing the reason to skip is hardcoded in this patch; if this patch will be chosen as the way to go then this text should be made into strings bundle (I have no idea how to do this).

Possible further improvements:
1.a Don't create those empty folders, or
1.b Put a faik email in those folders tellind the reason why this folder was skipped
2. Let user decide if (s)he wants to skip IMAP or not (this would require making some UI, that's beyond my skills).
Comment 4 Wayne Mery (:wsmwk, NI for questions) 2011-11-07 10:11:20 PST
this could be a nice perf win for import of large accounts
Comment 5 David :Bienvenu 2011-11-12 06:45:43 PST
Comment on attachment 563277 [details] [diff] [review]
Skip IMAP folders on import from Outlook

I ran with this, and it did skip the imap folders, but it created an empty folder with the name of the imap account - I'd prefer that it didn't do that, if possible. Other than that, I think it's OK to silently skip imap accounts. If we were actually creating the imap accounts and populating the imap offline store with the contents of the Outlook offline store, then I could see doing so (though I don't that would work technically because the version on the imap server is what we want).
Comment 6 David :Bienvenu 2011-11-18 12:40:06 PST
Comment on attachment 563710 [details] [diff] [review]
Alternative patch

minusing based on comments (don't want empty files)
Comment 7 David :Bienvenu 2011-11-18 12:40:55 PST
Mike, are you ok with my landing the first patch?
Comment 8 Mike Kaganski 2011-11-18 13:43:05 PST
David, of course, I'm OK with this.
However, I'd prefer at least to tell the user the reason why a mailbox was skipped...
Comment 9 David :Bienvenu 2011-11-18 13:50:55 PST
(In reply to Mike Kaganski from comment #8)
> David, of course, I'm OK with this.
> However, I'd prefer at least to tell the user the reason why a mailbox was
> skipped...

I think the better solution here would be to setup the imap account in Thunderbird, if there was an IMAP account in Outlook, and the corresponding account wasn't in Thunderbird.
Comment 10 Mark Banner (:standard8, limited time in Dec) 2011-11-23 02:39:16 PST
Checked in: http://hg.mozilla.org/comm-central/rev/1052fda15cbc

Note You need to log in before you can comment on or make changes to this bug.