690212 - Remove useless contextmenu listener in input.js

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Remove the contextmenu event listener from input.js

Since the ContextHelper class in common-ui.js fire a CancelTouchSequence event if there is a popup, this code is has become obsolete and can be removed safely.

It this also a hard dependancy to try to move the code to the toolkit.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 563279 [details] [diff] [review]
Remove the contextmenu event listener from input.js

Are you sure we don't need this for chrome contextmenus? Like the URL bar, bookmarks and other long tap menus in chrome?

Test a bit :)

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> Are you sure we don't need this for chrome contextmenus? Like the URL bar,
> bookmarks and other long tap menus in chrome?

I have tested on my side with panning in the Awesome Panel (which was the reason for this patch)!

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Vivien Nicolas (:vingtetun) from comment #2)
> (In reply to Mark Finkle (:mfinkle) from comment #1)
> > Are you sure we don't need this for chrome contextmenus? Like the URL bar,
> > bookmarks and other long tap menus in chrome?
> 
> I have tested on my side with panning in the Awesome Panel (which was the
> reason for this patch)!

Great!

Comment 4

[BMO Automation]

Closing all opened bug in a graveyard component