Closed Bug 690319 Opened 13 years ago Closed 13 years ago

Random orange: TEST-UNEXPECTED-FAIL | test-summarization.js | test_summarization_thread_detection (preceded by something like "Thought we would find row 0 at 92,-9 but we found -1")

Categories

(Thunderbird :: Mail Window Front End, defect)

7 Branch
All
Linux
defect
Not set
normal

Tracking

(thunderbird9 fixed)

RESOLVED FIXED
Thunderbird 10.0
Tracking Status
thunderbird9 --- fixed

People

(Reporter: standard8, Assigned: mconley)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

New random orange that has appeared in the last day or so:

Test Failure: Thought we would find row 0 at 92,-9 but we found -1
TEST-UNEXPECTED-FAIL | /buildbot/comm-central-linux-opt-unittest-mozmill/build/mozmill/folder-display/test-summarization.js | test_summarization_thread_detection

http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTrunk/1317293922.1317295330.14004.gz#err0

Seems pretty frequent, only on Linux so far.

Mike, would you be able to take a look at this?
Sure, I'll take a peek.
Assignee: nobody → mconley
Ok, I've tracked this down to the telemetry opt-in notification bar.  There's some kind of race condition going on here, where the message treeBox doesn't correctly execute ensureRowIsVisible when we expect.

Suppressing the telemetry opt-in prompt clears the orange.

I'm starting investigations on how this race condition works...
Protz might have some ideas on what changed there, too…
If the opt-in prompt for telemetry is fixing things, then either 1) telemetry is changing the focus, or 2) the notification bar is changing the positioning of the layout.

In either case, I'd be happy with just permanently disabling the telemetry opt-in notification for tests (as long as that doesn't break the telemetry tests ;-) ).

Telemetry also fits with the rough timeframe of the regression which is good.
Sorry, I thought about it real hard, and I couldn't come up with something nearly as smart as Mark's comment :)
I think it's your first suggestion - focus.  I've updated the Mozmill test helper that collapses threads to explicitly focus the tree, and that seems to have disappeared the orange.  I'll post it to try in a few minutes, and we'll see how it goes.
Comment on attachment 564297 [details] [diff] [review]
Patch v1

Looks like this cleared the orange.  Hooray!
Attachment #564297 - Flags: review?(mbanner)
Attachment #564297 - Flags: approval-comm-aurora?
Attachment #564297 - Flags: review?(mbanner)
Attachment #564297 - Flags: review+
Attachment #564297 - Flags: approval-comm-aurora?
Attachment #564297 - Flags: approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/55ac90d480ec
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
For future reference (adjust versions depending on the cycle):

(In reply to Mike Conley (:mconley) from comment #9)
> Committed to comm-central as
> http://hg.mozilla.org/comm-central/rev/23eab72a5925

Milestone -> Thunderbird 10 (we normally mark as fixed at that point as well).

(In reply to Mike Conley (:mconley) from comment #10)
> Committed to comm-aurora as
> http://hg.mozilla.org/releases/comm-aurora/rev/55ac90d480ec

status-thunderbird9 -> fixed.
Target Milestone: --- → Thunderbird 10.0
Ah, gotcha - thanks!

-Mike
Whiteboard: [tb-orange]
You need to log in before you can comment on or make changes to this bug.