Closed Bug 690326 Opened 11 years ago Closed 11 years ago

Simplify venkman-overlay for Thunderbird

Categories

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Product:
Other Applications Graveyard
Component:
Venkman JS Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.7 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla10
Tracking Flags:
Tracking Status
seamonkey2.7 --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: [qa?])

Attachments

(1 file)

Split venkman-overlay [Checked in: Comment 2]
7.35 KB, patch
Gijs
: review+
Details | Diff | Splinter Review 
At the moment there is a single venkman-overlay.xul but due to duplication of IDs, have to remove the TB menuitem using javascript.
This patch:
* Moves the TB part of the overlay to a separate file.
* Only overlays TB with the new file.
* Stops overlaying TB with the old file.
* Drops the javascript removal of the TB menuitem.
Attachment #563379 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 563379 [details] [diff] [review]
Split venkman-overlay [Checked in: Comment 2]

r=me
Attachment #563379 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 563379 [details] [diff] [review]
Split venkman-overlay [Checked in: Comment 2]

http://hg.mozilla.org/venkman/rev/7fce081822d4
Attachment #563379 - Attachment description: Split venkman-overlay → Split venkman-overlay [Checked in: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-firefox10: --- → fixed
status-seamonkey2.7: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Is this something that can be verified in Firefox 10 or is it Thunderbird-only?
Whiteboard: [qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #3)
> Is this something that can be verified in Firefox 10 or is it
> Thunderbird-only?

There should be no visible difference, so hard to verify. I've removed the status-firefox10 flag as apparently I shouldn't have set that.
status-firefox10: fixed → ---
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.