abcasm: coerce_o & coerce_u not supported, and bitnot as wrong stack effect.

RESOLVED FIXED in Q1 12 - Brannan

Status

Tamarin
Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Edwin Smith, Assigned: Edwin Smith)

Tracking

unspecified
Q1 12 - Brannan
Bug Flags:
in-testsuite ?
flashplayer-injection -
flashplayer-qrb +
flashplayer-bug +
flashplayer-triage +

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 563380 [details] [diff] [review]
Adds coerce_o, coerce_u, fixes bitnot.

Two missing opcodes and an off by one error.
(Assignee)

Updated

6 years ago
Assignee: nobody → edwsmith
(Assignee)

Updated

6 years ago
Attachment #563380 - Attachment is patch: true
Attachment #563380 - Flags: review?(tharwood)
(Assignee)

Comment 1

6 years ago
Created attachment 563391 [details] [diff] [review]
Additional coverage tests for coerce_o and coerce_u

Updated

6 years ago
Attachment #563380 - Flags: review?(tharwood) → review+

Comment 2

6 years ago
Comment on attachment 563391 [details] [diff] [review]
Additional coverage tests for coerce_o and coerce_u

Been a while since I worked on one of these, but it looks right.

Updated

6 years ago
Attachment #563391 - Flags: review+

Comment 3

6 years ago
changeset: 6609:c384ea3edf99
user:      Edwin Smith <edwsmith@adobe.com>
summary:   Bug 690329 - abcasm: coerce_o & coerce_u not supported, and bitnot as wrong stack effect (r=tharwood+)

http://hg.mozilla.org/tamarin-redux/rev/c384ea3edf99

Comment 4

6 years ago
Ed, can this be marked fixed?
Flags: in-testsuite?
Flags: flashplayer-triage+
Flags: flashplayer-qrb+
Flags: flashplayer-injection-
Flags: flashplayer-bug+
Target Milestone: --- → Q1 12 - Brannan

Comment 5

6 years ago
Appears fixed, marking so.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.