Closed Bug 690370 Opened 8 years ago Closed 8 years ago

Fx app update deletes customized pref defaults (defaults\pref\all.js)

Categories

(Toolkit :: Application Update, defect)

x86
Windows XP
defect
Not set

Tracking

()

VERIFIED WONTFIX

People

(Reporter: al_9x, Unassigned)

Details

1. unpack a non current nightly zip
2. add a defaults\pref\all.js
3. perform a help->about update
4. all.js gets deleted
custom prefs can be placed in /path/to/firefox/defaults/profile/user.js
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
These are not custom prefs, but custom defaults.  Why are they deleted?  An installer update does not delete them.
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
Installing on top of with the installer should delete them which I'll verify when I have a chance.

Custom preferences should be in a file that is not one of the Firefox prefs files under defaults\pref\.

The reason it is deleted is because this Firefox prefs file has been moved into the omni.jar file. Also, the old file contains values that have been changed and some of the changes will cause breakage.

Leaving open to verify that the installer does delete all.js, etc.
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
(In reply to Robert Strong [:rstrong] (do not email) from comment #3)
> Custom preferences should be in a file that is not one of the Firefox prefs
> files under defaults\pref\.

all.js does not appear to be a firefox installed file, it is neither in defaults\pref\ nor in omni.jar, so why again are you deleting a user supplied defaults file?
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---
Sorry about accidentally resolving it fixed.

Just had a chance to look into this and all.js was removed during an update as far back as Firefox 1.5
http://mxr.mozilla.org/mozilla1.8.0/source/browser/installer/removed-files.in#10

To prevent this from happening you will need to use a pref file name that has never been used by Firefox. A safe bet would be to prefix the file name with an _.

We aren't going to change Firefox so this file isn't deleted so wontfixing.
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → WONTFIX
(In reply to Robert Strong [:rstrong] (do not email) from comment #5)
> We aren't going to change Firefox so this file isn't deleted so wontfixing.

Deleting a user supplied defaults file is incorrect behavior, not saying this is a high priority, but WONTFIX is inappropriate, confirm it and leave it open.
Status: RESOLVED → UNCONFIRMED
Resolution: WONTFIX → ---
No, it isn't considered a user supplied defaults pref file because the all.js pref file used to exist in Firefox. This is why it is deleted it on update. Any pref file name that has ever existed is not considered supported. We are not going to change that policy and we aren't going to fix this bug so please don't reopen.
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → WONTFIX
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.