690474 - QA and deploy BrowserID train-2011.09.29 to production

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Labs, task)

Description

[Lloyd Hilaiel]

ChangeLog including issues resolved: 
https://github.com/mozilla/browserid/commit/fd2232

[QA] Suggested areas of focus for QA:
  * Cookies!  Verify that cookies sent by the server have an expiration date one week in the future
  * Basic regression testing - this train includes small changes that are not user visible.

[RELEASE ENGINEERING] Steps for updating production to train-2011.09.29

  No ad-hoc migration steps exist this week.  just push.

Comment 1

[James Bonacci [:jbonacci]]

QA will proceed with some testing of this Beta release starting Monday, 10/03/2011.

Comment 2

[James Bonacci [:jbonacci]]

Additional "hot" fixes added to Beta for testing:
329: need to sync time with server before signing assertion
240: verify on myfavoritebeer uses CORS request, which IE8/9 cannot do.

Comment 3

[Lloyd Hilaiel]

to be clear, 240 is in production now, but 329 is waiting for peer review and approval from ben adida and shane tomlinson.  I expect to have a decision on whether that fix will make it into this train (2011.09.29)  on by mid day tomorrow, and will update this ticket as soon as i know.

Comment 4

[James Bonacci [:jbonacci]]

OK, I must be confused.
I do not see 240 as a resolved issue for the 9-22 or 9-29 trains (the ChangeLogs), yet it is already out in Prod?
(well as of 8+ hours ago)
Oh, well - QA will compare functionality between Beta and Prod for this one.

Thanks for the update on 329.
(Will give me more time to find out how to snoop on cookie content across browsers)

Comment 5

[Lloyd Hilaiel]

Yo james.  I'm sorry for not being clearer.  For issue 240 the fix was only on myfavoritebeer, the demo site.  This is why the fix can go out without any update in changelogs, we treat that as a totally separate product.  The confusing part is that's the primary way we test browserid.   ungh.

Next, as of this moment 329 is in beta.  here's the ChangeLog updates for train-2011.09.29:

https://github.com/mozilla/browserid/commit/0e77230d03838ea88c9a277e78fb2858ca277b75

Comment 6

[James Bonacci [:jbonacci]]

OK. Got it.
Adding 204 just for the heck of it.
Will cover 329 as part of this Beta.
QA is picking this up again from here and testing Beta!

Comment 7

[James Bonacci [:jbonacci]]

QA signs off on the 9/29 train in Beta.
There are no immediate blockers, but the issues I found with Safari on iPhone must be investigated asap...

Details:
New issues:
351: Safari/Opera: BrowserID Account Manage page does not show emails
355: When closing the Signing in dialog from [X] in Opera, the Sign In button from http://beta.myfavoritebeer.org remains grayed out and unresponsive
360: BrowserID does not appear to be compatible with the Dolphin browser.
361: Fun with IE8
362: Compatibility issues using Safari on iPhone 4

Other Open Issues
323: reset password api call needed
325: For android support, server responses may not be 'false' or 'null'
329: need to sync time with server before signing assertion
335: Dialog needs error messages
336: Verification of email in different browser is broken
338: error message needed if password is too short.
341: Update new design to work with mobile
342: Safari on OSX errors trying to access relay frame.
344: Don't break when a client machine has a system clocks that is off by more than 2 minutes

Versions:
Beta:
https://diresworb.org/ver.txt
0e77230 update beta changelog with merged & external fixes

VERIFIED that BrowserID is indeed "broken" on IE9 in compatibility mode (where the Compatibility View icon is filled in with color - vs Off when it is gray outline).
I get an About:blank pop-up.

QA VERIFIED the following issues:
326: fix link on /developers page to verfier source: #326
285: UI flow for backing out of adding a new email address is broken in IE9
149: Beta and ux_iteration: unable to login using Opera on Win7
302: If logged in with another BrowserID email on a different browser, the user is logged out
287: Blocker: Getting permission denied errors trying to sign in to Beta beer site.
308: Logging into same account on different browsers does not show beer info
286: Cancelling Sign In and trying to Sign In again results in blank pop-up etc
329: (merged 2011.10.04) fix issue where a wrong-set client clock could prevent login
344: Don't break when a client machine has a system clocks that is off by more than 2 minutes
310: fix bug where session duration had an upper bound of 7 days - the time the server was running
309: fix bug where a user could go longer than 1 week without re-authenticating
240: (external fix in myfavoritebeer) IE9 support

And, of course,
Cookies!  Verify that cookies sent by the server have an expiration date one week in the future

Comment 8

[Lloyd Hilaiel]

beginning production push now.

Comment 9

[Lloyd Hilaiel]

now live in production: https://browserid.org/ver.txt