Closed Bug 690520 Opened 13 years ago Closed 13 years ago

plugin crash mozmill test should handle crash-reporter not being enabled

Categories

(Thunderbird :: Testing Infrastructure, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(thunderbird9 fixed)

RESOLVED FIXED
Thunderbird 10.0
Tracking Status
thunderbird9 --- fixed

People

(Reporter: Bienvenu, Assigned: mconley)

Details

Attachments

(1 file)

In the no good deed goes unpunished category(mconley writing mozmill tests for plugin crashes), I have the following issue: in debug builds (or, rather, any non-official build), crash-reporter is disabled, which makes the new plugin tests fail. I often (ok, sometimes) run the mozmill tests on a debug build, and it would be helpful if I didn't have to help those tests along by clicking on the crash dialog :-)
Assignee: nobody → mconley
Attached patch Patch v1Splinter Review
Sorry about that, bienvenu!

This patch checked out on both debug and non-debug builds on my Linux box.  On the debug builds, the crash tests are just skipped.
Attachment #563545 - Flags: review?(dbienvenu)
Attachment #563545 - Flags: approval-comm-aurora?
Comment on attachment 563545 [details] [diff] [review]
Patch v1

thx, Mike.
Attachment #563545 - Flags: review?(dbienvenu) → review+
Committed as http://hg.mozilla.org/comm-central/rev/2f9ac9b08d5a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attachment #563545 - Flags: approval-comm-aurora? → approval-comm-aurora+
Target Milestone: --- → Thunderbird 10.0
You need to log in before you can comment on or make changes to this bug.