690526 - Compose window address list won't resize smaller once made bigger

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Joe Drew (not getting mail)]

Put several addresses into your compose window. Resize the address list:

http://imgur.com/92faF

Now try to resize it smaller:

http://imgur.com/c6lsc

This seems to be a permanent state for the compose window now.

Comment 1

[Mark Banner (:standard8)]

That's an interesting one. Using DOM Inspector, I can find the toolbox element with id="FormatToolbar" and change its height to something small to reset the location of the bar.

Comment 2

[Mark Banner (:standard8)]

Err, I meant id="FormatToolbox"

Comment 3

[Jim Porter (:squib)]

Attachment: Fix this

So the issue here is that, previously, the next sibling of the splitter had flex="1" so everything worked out. Then the splitter got moved above the FormatToolbox, which wasn't flexy. The solution is to make the flexy vbox encompass both the FormatToolbox and the message body.

Here's a patch to do this, which is mostly indentation changes.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 563580 [details] [diff] [review]
Fix this

r=me. Please also use hg transplant to put this on aurora & beta. I don't think this will adversely affect extensions, and I'd like to push the fix out as soon as possible.

Comment 6

[Jim Porter (:squib)]

Checked in:

http://hg.mozilla.org/comm-central/rev/4ab5a3448398
http://hg.mozilla.org/releases/comm-aurora/rev/4cd6e224028d
http://hg.mozilla.org/releases/comm-beta/rev/f3abe099d38e