Closed Bug 690560 Opened 9 years ago Closed 9 years ago

make repack-l10n-all doesn't work correctly on Mac universal builds.

Categories

(Calendar :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

The repack-l10n-all target actually tries to repack in the i386 directory rather than the universal one. We need to find a way to fix that.
Attached patch Possible fixSplinter Review
This seems to fix the repack-l10n-all target, I'm not yet convinced it doesn't break normal l10n repacks.
Comment on attachment 564677 [details] [diff] [review]
Possible fix

Ok, this works for the release builds (I did 1.0rc1 Mac with this patch), and I'm pretty sure it'll work for L10n repacks as I've changed all the targets in that file and so it'll all just switch to the universal directory if it is a universal build.
Attachment #564677 - Flags: review?(philipp)
Comment on attachment 564677 [details] [diff] [review]
Possible fix

Looks good, r=philipp
Attachment #564677 - Flags: review?(philipp) → review+
Assignee: nobody → mbanner
Checked in: http://hg.mozilla.org/comm-central/rev/61eba1c8e780

Leaving open, as I want to remember to check the nightly l10n builds once they cycle today.
It turns out that I had broken l10n builds, I've pushed a bustage fix:

http://hg.mozilla.org/comm-central/rev/f61c89aaa748
Depends on: 696122
You need to log in before you can comment on or make changes to this bug.