Closed Bug 690585 Opened 8 years ago Closed 8 years ago

Report startup interruptions

Categories

(Toolkit :: Telemetry, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

Details

Attachments

(1 file)

No description provided.
Attachment #563572 - Flags: review?(mh+mozilla)
Duplicate of this bug: 691979
Blocks: 659396
Comment on attachment 563572 [details] [diff] [review]
report startupInterrupted

Review of attachment 563572 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetryPing.js
@@ +195,4 @@
>        ret[field] = si[field] - si.process
>      }
>    }
> +  ret.startupInterrupted = Services.startup.interrupted * 1;

Number(Services.startup.interrupted) would seem less strange.
Attachment #563572 - Flags: review?(mh+mozilla) → review+
Assignee: nobody → tglek
https://hg.mozilla.org/mozilla-central/rev/38ec795c6065
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla10
Eww. "new Number" creates an unnecessary object. Furthermore, that object behaves in subtly different way from primitive numbers.

A better way to coerce to number is with the unary + operator.
(In reply to Jesse Ruderman from comment #5)
> A better way to coerce to number is with the unary + operator.

I would prefer just removing the "new".
You need to log in before you can comment on or make changes to this bug.