release sanity should verify that shipped-locales doesn't have any locales that aren't in l10n-changesets

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: lsblakk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Reporter)

Updated

7 years ago
Blocks: 627271
(Assignee)

Updated

7 years ago
Assignee: nobody → lsblakk
(Assignee)

Comment 1

7 years ago
Created attachment 570383 [details] [diff] [review]
release_sanity compares l10n_changesets locales to shipped locales (for firefox)
Attachment #570383 - Flags: review?(bhearsum)
(Reporter)

Comment 2

7 years ago
Comment on attachment 570383 [details] [diff] [review]
release_sanity compares l10n_changesets locales to shipped locales (for firefox)

Review of attachment 570383 [details] [diff] [review]:
-----------------------------------------------------------------

::: buildbot-helpers/release_sanity.py
@@ +262,5 @@
> +    """Ensure that our l10n-changesets on the master match the repo's shipped locales list"""
> +    success = True
> +    shipped_locales = []
> +    try:
> +        shipped_locales_page = urllib2.urlopen(shipped_locales_url)

We've got library methods for dealing with shipped-locales. Have a look at getShippedLocales (http://hg.mozilla.org/build/tools/file/2b3920fd4a6e/lib/python/release/l10n.py#l16) and either getPlatformLocales or getAllLocales (http://hg.mozilla.org/build/tools/file/2b3920fd4a6e/lib/python/release/platforms.py#l51)

@@ +394,5 @@
>                  test_success = False
>                  log.error("Error verifying l10n dashboard changesets")
>  
> +            #verify that l10n changesets match the shipped locales in firefox product
> +            if releaseConfig['productName'] == 'firefox':

I think this block should be dependent on whether or not both shippedLocalesPath and l10nRevisionFile exists in releaseConfig. The product being Firefox doesn't guarantee that both of those exist, and basing it on attributes rather than products means that this would work for Thunderbird or any other products.
Attachment #570383 - Flags: review?(bhearsum) → review-
(Assignee)

Comment 3

7 years ago
Created attachment 570849 [details] [diff] [review]
release_sanity compares l10n_changesets locales to shipped locales

- checking for 'shippedLocalesPath' now so any product that uses this can benefit
- added a new function to lib/python/release/platforms.py that returns the list of shipped locales and am now using the existing getShippedLocales instead of my own url reading
Attachment #570383 - Attachment is obsolete: true
Attachment #570849 - Flags: review?(bhearsum)
(Reporter)

Updated

7 years ago
Attachment #570849 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 4

7 years ago
Comment on attachment 570849 [details] [diff] [review]
release_sanity compares l10n_changesets locales to shipped locales

http://hg.mozilla.org/build/tools/rev/92346382b571
Attachment #570849 - Flags: checked-in+
(Assignee)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Trying to retrieve from a tag which doesn't exist yet:

2011-11-02 21:08:05,586 : ERROR : Failed to retrieve http://hg.mozilla.org/releases/mozilla-beta/raw-file/FIREFOX_8_0b6_BUILD2/browser/locales/shipped-locales
Traceback (most recent call last):
  File "../tools/buildbot-helpers/release_sanity.py", line 407, in <module>
    sourceRepoPath
  File "/builds/buildbot/build1/tools/lib/python/release/l10n.py", line 24, in getShippedLocales
    sl = urlopen(url).read()
  File "/usr/lib64/python2.6/urllib2.py", line 126, in urlopen
    return _opener.open(url, data, timeout)
  File "/usr/lib64/python2.6/urllib2.py", line 397, in open
    response = meth(req, response)
  File "/usr/lib64/python2.6/urllib2.py", line 510, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib64/python2.6/urllib2.py", line 435, in error
    return self._call_chain(*args)
  File "/usr/lib64/python2.6/urllib2.py", line 369, in _call_chain
    result = func(*args)
  File "/usr/lib64/python2.6/urllib2.py", line 518, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 404: Not Found

We should use the rev we're supposed to be tagging instead.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 570849 [details] [diff] [review]
release_sanity compares l10n_changesets locales to shipped locales

Backed out - http://hg.mozilla.org/build/tools/rev/29a13d480a65
Attachment #570849 - Flags: checked-in+ → checked-in-
(Assignee)

Comment 7

7 years ago
Created attachment 571669 [details] [diff] [review]
v.2 release_sanity compares l10n_changesets locales to shipped locales for the revision about to be tagged

getShippedLocales now accepts a revision and if revision is present it assembles the shipped_locales path with that instead of cobbling together the release tag. Added revision=None to the end of the args for getShippedLocales so that nothing should break from this change.
Attachment #570849 - Attachment is obsolete: true
Attachment #571669 - Flags: review?(nrthomas)
Attachment #571669 - Flags: review?(nrthomas) → review+
(Assignee)

Comment 8

7 years ago
Comment on attachment 571669 [details] [diff] [review]
v.2 release_sanity compares l10n_changesets locales to shipped locales for the revision about to be tagged

http://hg.mozilla.org/build/tools/rev/e6f09c2c631d
Attachment #571669 - Flags: checked-in+
(Assignee)

Updated

7 years ago
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.